* so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset.
@ 2012-01-28 6:31 devendra.aaru
2012-01-28 16:44 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: devendra.aaru @ 2012-01-28 6:31 UTC (permalink / raw)
To: linux-wireless, netdev, linux-kernel
Hi wireless folks,
in _rtl92c_store_pwrIndex_diffrate_offset (
drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c), there are lot of
if conditions, checking the register address.
my understanding is that if the register address matches to a
particular rate, we set the txpower level to a particular group. but
it is even possible with the switch or if else if statements,
please correct me if i am wrong.
Thanks,
Dev.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset.
2012-01-28 6:31 so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset devendra.aaru
@ 2012-01-28 16:44 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2012-01-28 16:44 UTC (permalink / raw)
To: devendra.aaru; +Cc: linux-wireless, netdev, linux-kernel
On 01/28/2012 12:31 AM, devendra.aaru wrote:
> Hi wireless folks,
>
> in _rtl92c_store_pwrIndex_diffrate_offset (
> drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c), there are lot of
> if conditions, checking the register address.
> my understanding is that if the register address matches to a
> particular rate, we set the txpower level to a particular group. but
> it is even possible with the switch or if else if statements,
> please correct me if i am wrong.
Of course, that routine could be recoded using either a switch or if else
statements. Unfortunately, I have more pressing matters to attend to. You can,
however, submit a patch to change it and send it to the linux-wireless mailing
list. You must follow the instructions in Documentation/SubmittingPatches, and
the patch must apply using the wireless-testing git tree.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-28 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-28 6:31 so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset devendra.aaru
2012-01-28 16:44 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox