From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Marcos Paulo de Souza <marcos.mage@gmail.com>
Cc: len.brown@intel.com, pavel@ucw.cz, rjw@sisk.pl,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM/Suspend: Avoid code duplication in suspend statistics update
Date: Thu, 02 Feb 2012 07:20:37 +0530 [thread overview]
Message-ID: <4F29EBED.6060006@linux.vnet.ibm.com> (raw)
In-Reply-To: <1328146776-1766-1-git-send-email-marcos.mage@gmail.com>
On 02/02/2012 07:09 AM, Marcos Paulo de Souza wrote:
> The code
> if (error) {
> suspend_stats.fail++;
> dpm_save_failed_errno(error);
> } else
> suspend_stats.success++;
>
> Appears in the kernel/power/main.c and kernel/power/suspend.c.
>
> This patch just creates a new function to avoid duplicated code.
>
> Suggested-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
> ---
Looks good to me :-)
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
next prev parent reply other threads:[~2012-02-02 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 1:39 [PATCH] PM/Suspend: Avoid code duplication in suspend statistics update Marcos Paulo de Souza
2012-02-02 1:50 ` Srivatsa S. Bhat [this message]
2012-02-02 19:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F29EBED.6060006@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marcos.mage@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).