* [PATCH V1] mfd: tps65910: Initialize irq platform data properly
@ 2012-01-18 14:49 Laxman Dewangan
2012-02-02 13:56 ` Laxman Dewangan
2012-02-20 16:45 ` Samuel Ortiz
0 siblings, 2 replies; 5+ messages in thread
From: Laxman Dewangan @ 2012-01-18 14:49 UTC (permalink / raw)
To: sameo, linux-kernel; +Cc: linux-tegra, ldewangan
irq_base of the tps65910 irq platform data should be
initialized with the board provided irq_base data.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
drivers/mfd/tps65910.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index c1da84b..8517481 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
goto err;
init_data->irq = pmic_plat_data->irq;
- init_data->irq_base = pmic_plat_data->irq;
+ init_data->irq_base = pmic_plat_data->irq_base;
tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
--
1.7.1.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mfd: tps65910: Initialize irq platform data properly
2012-01-18 14:49 [PATCH V1] mfd: tps65910: Initialize irq platform data properly Laxman Dewangan
@ 2012-02-02 13:56 ` Laxman Dewangan
2012-02-19 7:34 ` Laxman Dewangan
2012-02-20 16:45 ` Samuel Ortiz
1 sibling, 1 reply; 5+ messages in thread
From: Laxman Dewangan @ 2012-02-02 13:56 UTC (permalink / raw)
To: Laxman Dewangan, sameo@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Mark Brown, Grant Likely, Linus Walleij
On Wednesday 18 January 2012 08:19 PM, Laxman Dewangan wrote:
> irq_base of the tps65910 irq platform data should be
> initialized with the board provided irq_base data.
>
> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> ---
> drivers/mfd/tps65910.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index c1da84b..8517481 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
> goto err;
>
> init_data->irq = pmic_plat_data->irq;
> - init_data->irq_base = pmic_plat_data->irq;
> + init_data->irq_base = pmic_plat_data->irq_base;
>
> tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
>
Hi Samuel,
Any feedback on this patch?
Thanks,
Laxman
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mfd: tps65910: Initialize irq platform data properly
2012-02-02 13:56 ` Laxman Dewangan
@ 2012-02-19 7:34 ` Laxman Dewangan
0 siblings, 0 replies; 5+ messages in thread
From: Laxman Dewangan @ 2012-02-19 7:34 UTC (permalink / raw)
To: Laxman Dewangan
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Mark Brown, Grant Likely,
Linus Walleij
Hi Samuel,
Can you please review this patch? Without this change, the device is
corrupting other irq registration because it tries to register wrong irqs.
Thanks,
Laxman
On Thursday 02 February 2012 07:26 PM, Laxman Dewangan wrote:
> On Wednesday 18 January 2012 08:19 PM, Laxman Dewangan wrote:
>> irq_base of the tps65910 irq platform data should be
>> initialized with the board provided irq_base data.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>> ---
>> drivers/mfd/tps65910.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
>> index c1da84b..8517481 100644
>> --- a/drivers/mfd/tps65910.c
>> +++ b/drivers/mfd/tps65910.c
>> @@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
>> goto err;
>>
>> init_data->irq = pmic_plat_data->irq;
>> - init_data->irq_base = pmic_plat_data->irq;
>> + init_data->irq_base = pmic_plat_data->irq_base;
>>
>> tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
>>
> Hi Samuel,
> Any feedback on this patch?
>
> Thanks,
> Laxman
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mfd: tps65910: Initialize irq platform data properly
2012-01-18 14:49 [PATCH V1] mfd: tps65910: Initialize irq platform data properly Laxman Dewangan
2012-02-02 13:56 ` Laxman Dewangan
@ 2012-02-20 16:45 ` Samuel Ortiz
2012-02-21 5:38 ` Laxman Dewangan
1 sibling, 1 reply; 5+ messages in thread
From: Samuel Ortiz @ 2012-02-20 16:45 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: linux-kernel, linux-tegra
Hi Laxman,
On Wed, Jan 18, 2012 at 08:19:16PM +0530, Laxman Dewangan wrote:
> irq_base of the tps65910 irq platform data should be
> initialized with the board provided irq_base data.
Thanks, patch applied to both my for-next and for-linus branches.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] mfd: tps65910: Initialize irq platform data properly
2012-02-20 16:45 ` Samuel Ortiz
@ 2012-02-21 5:38 ` Laxman Dewangan
0 siblings, 0 replies; 5+ messages in thread
From: Laxman Dewangan @ 2012-02-21 5:38 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Thanks Samuel for taking care.
On Monday 20 February 2012 10:15 PM, Samuel Ortiz wrote:
> Hi Laxman,
>
> On Wed, Jan 18, 2012 at 08:19:16PM +0530, Laxman Dewangan wrote:
>> irq_base of the tps65910 irq platform data should be
>> initialized with the board provided irq_base data.
> Thanks, patch applied to both my for-next and for-linus branches.
>
> Cheers,
> Samuel.
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-21 5:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-18 14:49 [PATCH V1] mfd: tps65910: Initialize irq platform data properly Laxman Dewangan
2012-02-02 13:56 ` Laxman Dewangan
2012-02-19 7:34 ` Laxman Dewangan
2012-02-20 16:45 ` Samuel Ortiz
2012-02-21 5:38 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox