public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [Patch] avr32: select GENERIC_ATOMIC64
@ 2012-02-03  7:03 Cong Wang
  2012-02-03  7:36 ` Hans-Christian Egtvedt
  0 siblings, 1 reply; 3+ messages in thread
From: Cong Wang @ 2012-02-03  7:03 UTC (permalink / raw)
  To: linux-kernel
  Cc: Andrew Morton, Haavard Skinnemoen, Hans-Christian Egtvedt,
	WANG Cong

avr32 doesn't implement atomic64_ operations, if not select this,
we would get:

kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter'
kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'

Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

---
diff --git a/arch/avr32/Kconfig b/arch/avr32/Kconfig
index 197e96f..6ecb8f4 100644
--- a/arch/avr32/Kconfig
+++ b/arch/avr32/Kconfig
@@ -11,6 +11,7 @@ config AVR32
 	select HARDIRQS_SW_RESEND
 	select GENERIC_IRQ_SHOW
 	select ARCH_HAVE_NMI_SAFE_CMPXCHG
+	select GENERIC_ATOMIC64
 	help
 	  AVR32 is a high-performance 32-bit RISC microprocessor core,
 	  designed for cost-sensitive embedded applications, with particular

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch] avr32: select GENERIC_ATOMIC64
  2012-02-03  7:03 [Patch] avr32: select GENERIC_ATOMIC64 Cong Wang
@ 2012-02-03  7:36 ` Hans-Christian Egtvedt
  2012-02-03  7:39   ` Cong Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Hans-Christian Egtvedt @ 2012-02-03  7:36 UTC (permalink / raw)
  To: Cong Wang; +Cc: linux-kernel, Andrew Morton, Haavard Skinnemoen

Around Fri 03 Feb 2012 15:03:00 +0800 or thereabout, Cong Wang wrote:
> avr32 doesn't implement atomic64_ operations, if not select this,
> we would get:
> 
> kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter'
> kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'
> 
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>

Thanks Cong, but Fabio beat you to it; https://lkml.org/lkml/2012/2/2/406

The above patch (similar to yours), was just pulled into Andrews tree.

> ---
> diff --git a/arch/avr32/Kconfig b/arch/avr32/Kconfig
> index 197e96f..6ecb8f4 100644
> --- a/arch/avr32/Kconfig
> +++ b/arch/avr32/Kconfig
> @@ -11,6 +11,7 @@ config AVR32
>  	select HARDIRQS_SW_RESEND
>  	select GENERIC_IRQ_SHOW
>  	select ARCH_HAVE_NMI_SAFE_CMPXCHG
> +	select GENERIC_ATOMIC64
>  	help
>  	  AVR32 is a high-performance 32-bit RISC microprocessor core,
>  	  designed for cost-sensitive embedded applications, with particular

-- 
mvh
Hans-Christian Egtvedt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch] avr32: select GENERIC_ATOMIC64
  2012-02-03  7:36 ` Hans-Christian Egtvedt
@ 2012-02-03  7:39   ` Cong Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Cong Wang @ 2012-02-03  7:39 UTC (permalink / raw)
  To: Hans-Christian Egtvedt; +Cc: linux-kernel, Andrew Morton, Haavard Skinnemoen

On 02/03/2012 03:36 PM, Hans-Christian Egtvedt wrote:
> Around Fri 03 Feb 2012 15:03:00 +0800 or thereabout, Cong Wang wrote:
>> avr32 doesn't implement atomic64_ operations, if not select this,
>> we would get:
>>
>> kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter'
>> kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'
>>
>> Cc: Haavard Skinnemoen<hskinnemoen@gmail.com>
>> Cc: Hans-Christian Egtvedt<egtvedt@samfundet.no>
>> Signed-off-by: WANG Cong<xiyou.wangcong@gmail.com>
>
> Thanks Cong, but Fabio beat you to it; https://lkml.org/lkml/2012/2/2/406
>
> The above patch (similar to yours), was just pulled into Andrews tree.

Yeah, then ignore mine. :)

Thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-03  7:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-03  7:03 [Patch] avr32: select GENERIC_ATOMIC64 Cong Wang
2012-02-03  7:36 ` Hans-Christian Egtvedt
2012-02-03  7:39   ` Cong Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox