From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ram Pai <linuxram@us.ibm.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Geert Uytterhoeven <geert@linux-m68k.org>, <trivial@kernel.org>
Subject: Re: [Patch] resource: move EXPORT_SYMBOL right after definition
Date: Fri, 3 Feb 2012 11:17:18 -0500 [thread overview]
Message-ID: <4F2C088E.3090106@windriver.com> (raw)
In-Reply-To: <1328276573-15265-1-git-send-email-xiyou.wangcong@gmail.com>
On 12-02-03 08:42 AM, Cong Wang wrote:
> EXPORT_SYMBOL(adjust_resource) should be right after adjust_resource().
Presumably this is to get rid of a checkpatch warning?
Maybe it makes sense to have it go via the trivial tree?
TRIVIAL PATCHES
M: Jiri Kosina <trivial@kernel.org>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
Paul.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 7640b3a..7e8ea66 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -749,6 +749,7 @@ int adjust_resource(struct resource *res, resource_size_t start, resource_size_t
> write_unlock(&resource_lock);
> return result;
> }
> +EXPORT_SYMBOL(adjust_resource);
>
> static void __init __reserve_region_with_split(struct resource *root,
> resource_size_t start, resource_size_t end,
> @@ -792,8 +793,6 @@ void __init reserve_region_with_split(struct resource *root,
> write_unlock(&resource_lock);
> }
>
> -EXPORT_SYMBOL(adjust_resource);
> -
> /**
> * resource_alignment - calculate resource's alignment
> * @res: resource pointer
next prev parent reply other threads:[~2012-02-03 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 13:42 [Patch] resource: move EXPORT_SYMBOL right after definition Cong Wang
2012-02-03 16:17 ` Paul Gortmaker [this message]
2012-02-04 7:10 ` Cong Wang
2012-02-04 9:59 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C088E.3090106@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=trivial@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox