From: Pavel Emelyanov <xemul@parallels.com>
To: Tejun Heo <tj@kernel.org>
Cc: Andrew Vagin <avagin@openvz.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Roland McGrath <roland@redhat.com>,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: Re: [PATCH] ptrace: add ability to get clear_tid_address
Date: Fri, 03 Feb 2012 20:45:07 +0400 [thread overview]
Message-ID: <4F2C0F13.70709@parallels.com> (raw)
In-Reply-To: <20120203162519.GB805@google.com>
On 02/03/2012 08:25 PM, Tejun Heo wrote:
> On Fri, Feb 03, 2012 at 02:11:23PM +0300, Andrew Vagin wrote:
>> Zero is written at clear_tid_address, when the process exits.
>> This functionality is used by pthread_join().
>>
>> sys_set_tid_address() changes this address for current task.
>>
>> Before this patch clear_tid_address could not be got from user space.
>> I want to dump a full state of a task, so I need this address.
>> Also I think it may be useful for debugging a multithreading program.
>>
>> I am not sure that ptrace is suitable place. It may be added in prctl,
>> but I think it's a bit useless and strange. I can't image a real
>> situation (avoid checkpointing) when a thread will want to get own
>> clear_tid_address from itself, this address is used by parent ussually.
>>
>> Signed-off-by: Andrew Vagin <avagin@openvz.org>
>
> Ummm... this really doesn't fit in ptrace. Cyrill, why not put it
> together with other params you're exporting?
Because there's no need for current to get this value of himself, but can
be useful for e.g. gdb. But we don't insist. Prctl extension is just fine.
> Thanks.
>
next prev parent reply other threads:[~2012-02-03 16:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 11:11 [PATCH] ptrace: add ability to get clear_tid_address Andrew Vagin
2012-02-03 16:25 ` Tejun Heo
2012-02-03 16:30 ` Cyrill Gorcunov
2012-02-03 16:41 ` Oleg Nesterov
2012-02-03 16:54 ` Cyrill Gorcunov
2012-02-03 16:45 ` Pavel Emelyanov [this message]
2012-02-03 16:51 ` Oleg Nesterov
2012-02-07 20:07 ` Pedro Alves
2012-02-07 20:56 ` Cyrill Gorcunov
2012-02-07 21:15 ` Pedro Alves
2012-02-07 21:51 ` Cyrill Gorcunov
2012-02-08 12:30 ` Pedro Alves
2012-02-08 12:42 ` Cyrill Gorcunov
2012-02-08 17:31 ` Oleg Nesterov
2012-02-08 18:04 ` Pedro Alves
2012-02-08 19:02 ` Oleg Nesterov
2012-02-08 19:20 ` Cyrill Gorcunov
2012-02-08 19:21 ` Jan Kratochvil
2012-02-08 19:42 ` Pedro Alves
2012-02-08 13:41 ` Andrew Vagin
2012-02-08 18:12 ` Jan Kratochvil
2012-02-10 3:02 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C0F13.70709@parallels.com \
--to=xemul@parallels.com \
--cc=avagin@openvz.org \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox