From: Arjan van de Ven <arjan@linux.intel.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Jesper Juhl <jj@chaosbits.net>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH][Trivial] Fix up version number reference in include/trace/events/power.h
Date: Fri, 03 Feb 2012 13:51:21 -0800 [thread overview]
Message-ID: <4F2C56D9.8010801@linux.intel.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1202032241380.25026@pobox.suse.cz>
On 2/3/2012 1:42 PM, Jiri Kosina wrote:
> On Sun, 15 Jan 2012, Jesper Juhl wrote:
>
>>>> -/* This code will be removed after deprecation time exceeded (2.6.41) */
>>>> +/* This code will be removed after deprecation time exceeded (3.1) */
>>>
>>> Shouldn't the real fix be to remove this code? What's the use of
>>> changing the version number that this code will be removed from, when
>>> the change won't get in until after the version that this code should
>>> have been removed?
>>>
>>> This is like updating 2014 calendars to say the world will end in 2012.
>>>
>> Heh, yeah, in a way you are right. But we have lots of code in the kernel
>> that says it will be removed at <some date in the past>, so I just figured
>> that if this code ends up hanging around it should at least display the
>> correct version number for when it /should/ have been removed.
>> The actual removal I'll leave up to others.
>
> Funny thing. Okay, this doesn't seem to be in linux-next, so I am taking
> it.
>
> Steven, planning to drop the code in a near future? :)
we shouldn't be dropping these yet.. tools are still using them.
and there really is no cost to keeping them either.
next prev parent reply other threads:[~2012-02-03 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 20:48 [PATCH][Trivial] Fix up version number reference in include/trace/events/power.h Jesper Juhl
2012-01-15 21:09 ` Steven Rostedt
2012-01-15 21:12 ` Jesper Juhl
2012-02-03 21:42 ` Jiri Kosina
2012-02-03 21:51 ` Arjan van de Ven [this message]
2012-02-04 15:15 ` Steven Rostedt
2012-02-04 22:31 ` Jesper Juhl
2012-02-06 19:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C56D9.8010801@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=jj@chaosbits.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox