* [Patch] resource: move EXPORT_SYMBOL right after definition
@ 2012-02-03 13:42 Cong Wang
2012-02-03 16:17 ` Paul Gortmaker
0 siblings, 1 reply; 4+ messages in thread
From: Cong Wang @ 2012-02-03 13:42 UTC (permalink / raw)
To: linux-kernel
Cc: Andrew Morton, WANG Cong, Ram Pai, Paul Gortmaker, Jesse Barnes,
Geert Uytterhoeven
EXPORT_SYMBOL(adjust_resource) should be right after adjust_resource().
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
diff --git a/kernel/resource.c b/kernel/resource.c
index 7640b3a..7e8ea66 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -749,6 +749,7 @@ int adjust_resource(struct resource *res, resource_size_t start, resource_size_t
write_unlock(&resource_lock);
return result;
}
+EXPORT_SYMBOL(adjust_resource);
static void __init __reserve_region_with_split(struct resource *root,
resource_size_t start, resource_size_t end,
@@ -792,8 +793,6 @@ void __init reserve_region_with_split(struct resource *root,
write_unlock(&resource_lock);
}
-EXPORT_SYMBOL(adjust_resource);
-
/**
* resource_alignment - calculate resource's alignment
* @res: resource pointer
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Patch] resource: move EXPORT_SYMBOL right after definition
2012-02-03 13:42 [Patch] resource: move EXPORT_SYMBOL right after definition Cong Wang
@ 2012-02-03 16:17 ` Paul Gortmaker
2012-02-04 7:10 ` Cong Wang
0 siblings, 1 reply; 4+ messages in thread
From: Paul Gortmaker @ 2012-02-03 16:17 UTC (permalink / raw)
To: Cong Wang
Cc: linux-kernel, Andrew Morton, Ram Pai, Jesse Barnes,
Geert Uytterhoeven, trivial
On 12-02-03 08:42 AM, Cong Wang wrote:
> EXPORT_SYMBOL(adjust_resource) should be right after adjust_resource().
Presumably this is to get rid of a checkpatch warning?
Maybe it makes sense to have it go via the trivial tree?
TRIVIAL PATCHES
M: Jiri Kosina <trivial@kernel.org>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial.git
Paul.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> ---
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 7640b3a..7e8ea66 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -749,6 +749,7 @@ int adjust_resource(struct resource *res, resource_size_t start, resource_size_t
> write_unlock(&resource_lock);
> return result;
> }
> +EXPORT_SYMBOL(adjust_resource);
>
> static void __init __reserve_region_with_split(struct resource *root,
> resource_size_t start, resource_size_t end,
> @@ -792,8 +793,6 @@ void __init reserve_region_with_split(struct resource *root,
> write_unlock(&resource_lock);
> }
>
> -EXPORT_SYMBOL(adjust_resource);
> -
> /**
> * resource_alignment - calculate resource's alignment
> * @res: resource pointer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] resource: move EXPORT_SYMBOL right after definition
2012-02-03 16:17 ` Paul Gortmaker
@ 2012-02-04 7:10 ` Cong Wang
2012-02-04 9:59 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Cong Wang @ 2012-02-04 7:10 UTC (permalink / raw)
To: Paul Gortmaker
Cc: linux-kernel, Andrew Morton, Ram Pai, Jesse Barnes,
Geert Uytterhoeven, trivial
On 02/04/2012 12:17 AM, Paul Gortmaker wrote:
> On 12-02-03 08:42 AM, Cong Wang wrote:
>> EXPORT_SYMBOL(adjust_resource) should be right after adjust_resource().
>
> Presumably this is to get rid of a checkpatch warning?
> Maybe it makes sense to have it go via the trivial tree?
>
Yeah, although I found this by code review, I agree this is proper for
trivial.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch] resource: move EXPORT_SYMBOL right after definition
2012-02-04 7:10 ` Cong Wang
@ 2012-02-04 9:59 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2012-02-04 9:59 UTC (permalink / raw)
To: Cong Wang
Cc: Paul Gortmaker, linux-kernel, Andrew Morton, Ram Pai,
Jesse Barnes, Geert Uytterhoeven
On Sat, 4 Feb 2012, Cong Wang wrote:
> > > EXPORT_SYMBOL(adjust_resource) should be right after adjust_resource().
> >
> > Presumably this is to get rid of a checkpatch warning?
> > Maybe it makes sense to have it go via the trivial tree?
> >
>
> Yeah, although I found this by code review, I agree this is proper for
> trivial.
I have already applied it yesterday.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-04 9:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-03 13:42 [Patch] resource: move EXPORT_SYMBOL right after definition Cong Wang
2012-02-03 16:17 ` Paul Gortmaker
2012-02-04 7:10 ` Cong Wang
2012-02-04 9:59 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox