public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Williamson <michael.williamson@criticallink.com>
To: "Manjunathappa, Prakash" <prakash.pm@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	davinci-linux-open-source@linux.davincidsp.com,
	Russell King <linux@arm.linux.org.uk>,
	Samuel Ortiz <sameo@linux.intel.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 3/3] arm:davinci: move NAND and NOR devices as aemif MFD slaves
Date: Tue, 07 Feb 2012 11:45:33 -0500	[thread overview]
Message-ID: <4F31552D.9060505@criticallink.com> (raw)
In-Reply-To: <1328627513-30134-4-git-send-email-prakash.pm@ti.com>

Hello Prakash,

On 2/7/2012 10:11 AM, Manjunathappa, Prakash wrote:

> NAND and NOR device are made as aemif device slaves, hence all DaVinci
> board NAND/NOR device registration achieved via aemif MFD driver.
>
> Signed-off-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> ---
> Since v2:
> Make changes for all DaVinci boards in single patch.



[...]

> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c
> index 672d820..bb29b7a 100644
> --- a/arch/arm/mach-davinci/board-mityomapl138.c
> +++ b/arch/arm/mach-davinci/board-mityomapl138.c
> @@ -19,6 +19,7 @@
>  #include <linux/etherdevice.h>
>  #include <linux/spi/spi.h>
>  #include <linux/spi/flash.h>
> +#include <linux/mfd/davinci_aemif.h>
>  
>  #include <asm/io.h>
>  #include <asm/mach-types.h>
> @@ -414,18 +415,35 @@ static struct resource mityomapl138_nandflash_resource[] = {
>  	},
>  };
>  
> -static struct platform_device mityomapl138_nandflash_device = {
> -	.name		= "davinci_nand",
> -	.id		= 1,
> -	.dev		= {
> -		.platform_data	= &mityomapl138_nandflash_data,
> +static struct platform_device mityomapl138_emif_devices[] __initdata = {
> +	{
> +		.name		= "davinci_nand",
> +		.id		= 0,



Pretty sure this still needs to be a 1.  The nand is on chip select 3,
EMA_CS3, which I believe is the same as the da850 EVM.

-Mike



  reply	other threads:[~2012-02-07 16:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 15:11 [PATCH v3 0/3] Moving EMIF driver to MFD framework Manjunathappa, Prakash
2012-02-07 15:11 ` [PATCH v3 1/3] arm:davinci: prepare to move aemif driver to drivers/mfd Manjunathappa, Prakash
2012-02-07 15:11 ` [PATCH v3 2/3] arm:davinci: Move emif driver to drivers/mfd from mach-davinci folder Manjunathappa, Prakash
2012-02-07 15:11 ` [PATCH v3 3/3] arm:davinci: move NAND and NOR devices as aemif MFD slaves Manjunathappa, Prakash
2012-02-07 16:45   ` Michael Williamson [this message]
2012-02-08  4:00     ` Manjunathappa, Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F31552D.9060505@criticallink.com \
    --to=michael.williamson@criticallink.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=prakash.pm@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox