linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Alan Cox <alan@linux.intel.com>, Sam Ravnborg <sam@ravnborg.org>,
	Arnd Bergmann <arnd@arndb.de>, Greg KH <gregkh@suse.de>,
	Jiri Slaby <jslaby@suse.cz>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/
Date: Wed, 08 Feb 2012 11:30:35 +0100	[thread overview]
Message-ID: <4F324ECB.7040102@gmail.com> (raw)
In-Reply-To: <20120105232142.GA10870@windriver.com>

On 01/06/2012 12:21 AM, Paul Gortmaker wrote:
> --- /dev/null
> +++ b/drivers/tty/serial/8250/Makefile
> @@ -0,0 +1,20 @@
> +#
> +# Makefile for the 8250 serial device drivers.
> +#
> +
> +obj-$(CONFIG_SERIAL_8250)		+= 8250.o
> +obj-$(CONFIG_SERIAL_8250_PNP)		+= 8250_pnp.o
> +obj-$(CONFIG_SERIAL_8250_GSC)		+= 8250_gsc.o
> +obj-$(CONFIG_SERIAL_8250_PCI)		+= 8250_pci.o
> +obj-$(CONFIG_SERIAL_8250_HP300)		+= 8250_hp300.o
> +obj-$(CONFIG_SERIAL_8250_CS)		+= serial_cs.o
> +obj-$(CONFIG_SERIAL_8250_ACORN)		+= 8250_acorn.o
> +obj-$(CONFIG_SERIAL_8250_CONSOLE)	+= 8250_early.o
> +obj-$(CONFIG_SERIAL_8250_FOURPORT)	+= 8250_fourport.o
> +obj-$(CONFIG_SERIAL_8250_ACCENT)	+= 8250_accent.o
> +obj-$(CONFIG_SERIAL_8250_BOCA)		+= 8250_boca.o
> +obj-$(CONFIG_SERIAL_8250_EXAR_ST16C554)	+= 8250_exar_st16c554.o
> +obj-$(CONFIG_SERIAL_8250_HUB6)		+= 8250_hub6.o
> +obj-$(CONFIG_SERIAL_8250_MCA)		+= 8250_mca.o
> +obj-$(CONFIG_SERIAL_8250_FSL)		+= 8250_fsl.o
> +obj-$(CONFIG_SERIAL_8250_DW)		+= 8250_dw.o

...

> diff --git a/drivers/tty/serial/m32r_sio.c b/drivers/tty/serial/8250/m32r_sio.c
> similarity index 100%
> rename from drivers/tty/serial/m32r_sio.c
> rename to drivers/tty/serial/8250/m32r_sio.c
> diff --git a/drivers/tty/serial/m32r_sio.h b/drivers/tty/serial/8250/m32r_sio.h
> similarity index 100%
> rename from drivers/tty/serial/m32r_sio.h
> rename to drivers/tty/serial/8250/m32r_sio.h
> diff --git a/drivers/tty/serial/m32r_sio_reg.h b/drivers/tty/serial/8250/m32r_sio_reg.h
> similarity index 100%
> rename from drivers/tty/serial/m32r_sio_reg.h
> rename to drivers/tty/serial/8250/m32r_sio_reg.h

Hmm, these cannot be built now :(. Why did you move them?

It looks like they should be moved back.

regards,
-- 
js

  parent reply	other threads:[~2012-02-08 10:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 20:01 [PATCH] serial: relocate remaining serial drivers from tty/ to tty/serial/ Paul Gortmaker
2012-01-04 20:34 ` Jiri Slaby
2012-01-04 20:51   ` Greg KH
2012-01-04 21:07     ` Paul Gortmaker
2012-01-04 22:03       ` Greg KH
2012-01-04 23:27         ` Arnd Bergmann
2012-01-05  5:42           ` Sam Ravnborg
2012-01-05 12:45             ` Alan Cox
2012-01-05 23:21               ` Paul Gortmaker
2012-01-06 13:42                 ` Greg KH
2012-02-08 10:30                 ` Jiri Slaby [this message]
2012-02-08 10:32                   ` Jiri Slaby
2012-02-08 13:58                     ` Paul Gortmaker
2012-02-08 14:12                     ` Paul Gortmaker
2012-01-04 22:01 ` Alan Cox
2012-01-04 22:43   ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F324ECB.7040102@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=alan@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@suse.de \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).