From: Jens Axboe <axboe@kernel.dk>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bsg: fix sysfs link remove warning
Date: Wed, 08 Feb 2012 20:04:36 +0100 [thread overview]
Message-ID: <4F32C744.9050400@kernel.dk> (raw)
In-Reply-To: <20120208172306.GA2301@redhat.com>
On 02/08/2012 06:23 PM, Stanislaw Gruszka wrote:
> We create "bsg" link if q->kobj.sd is not NULL, so remove it only
> when the same condition is true.
>
> Fixes:
>
> WARNING: at fs/sysfs/inode.c:323 sysfs_hash_and_remove+0x2b/0x77()
> sysfs: can not remove 'bsg', no directory
> Call Trace:
> [<c0429683>] warn_slowpath_common+0x6a/0x7f
> [<c0537a68>] ? sysfs_hash_and_remove+0x2b/0x77
> [<c042970b>] warn_slowpath_fmt+0x2b/0x2f
> [<c0537a68>] sysfs_hash_and_remove+0x2b/0x77
> [<c053969a>] sysfs_remove_link+0x20/0x23
> [<c05d88f1>] bsg_unregister_queue+0x40/0x6d
> [<c0692263>] __scsi_remove_device+0x31/0x9d
> [<c069149f>] scsi_forget_host+0x41/0x52
> [<c0689fa9>] scsi_remove_host+0x71/0xe0
> [<f7de5945>] quiesce_and_remove_host+0x51/0x83 [usb_storage]
> [<f7de5a1e>] usb_stor_disconnect+0x18/0x22 [usb_storage]
> [<c06c29de>] usb_unbind_interface+0x4e/0x109
> [<c067a80f>] __device_release_driver+0x6b/0xa6
> [<c067a861>] device_release_driver+0x17/0x22
> [<c067a46a>] bus_remove_device+0xd6/0xe6
> [<c06785e2>] device_del+0xf2/0x137
> [<c06c101f>] usb_disable_device+0x94/0x1a0
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Thanks, applied.
--
Jens Axboe
prev parent reply other threads:[~2012-02-08 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 17:23 [PATCH] bsg: fix sysfs link remove warning Stanislaw Gruszka
2012-02-08 19:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F32C744.9050400@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).