From: Jens Axboe <axboe@kernel.dk>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdrom: move shared static to cdrom_device_info
Date: Wed, 08 Feb 2012 20:05:02 +0100 [thread overview]
Message-ID: <4F32C75E.2000807@kernel.dk> (raw)
In-Reply-To: <1328722329-22728-1-git-send-email-pbonzini@redhat.com>
On 02/08/2012 06:32 PM, Paolo Bonzini wrote:
> The keeplocked variable in the cdrom driver is shared across multiple
> drives, but set in per-device ioctls. Move it to the per-device struct,
> avoiding that the setting on one drive affects the driver's behavior
> when closing another.
>
> [ Impact: limit udev's confusion to one drive when a CD burning program
> unlocks the CD door at the end of burning. ]
>
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> Would this be acceptable for 3.3?
Yeah, looks simple enough. I thought we had a module parameter for this
too, but we do not. So I've applied it for 3.3.
--
Jens Axboe
prev parent reply other threads:[~2012-02-08 19:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 17:32 [PATCH] cdrom: move shared static to cdrom_device_info Paolo Bonzini
2012-02-08 17:32 ` Paolo Bonzini
2012-02-08 19:05 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F32C75E.2000807@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).