From: Laxman Dewangan <ldewangan@nvidia.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"lrg@ti.com" <lrg@ti.com>,
"jedu@slimlogic.co.uk" <jedu@slimlogic.co.uk>,
"gg@slimlogic.co.uk" <gg@slimlogic.co.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V1 1/2] mfd: tps65910: use regmap for device register access.
Date: Thu, 9 Feb 2012 17:29:38 +0530 [thread overview]
Message-ID: <4F33B52A.5020900@nvidia.com> (raw)
In-Reply-To: <20120209115502.GD3058@opensource.wolfsonmicro.com>
On Thursday 09 February 2012 05:25 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Thu, Feb 09, 2012 at 10:33:01AM +0530, Laxman Dewangan wrote:
>> On Wednesday 08 February 2012 07:28 PM, Mark Brown wrote:
>>> But that's just raw_write(), there's no benefit to the additional API
>>> call.
>> raw_write supported for the volatile register only.
>
> Note that there's a very important difference between the bulk and raw
> versions of the API which you're not taking into account: the bulk
> version takes care of endianness differences between the device and the
> host. This would mean that for send we'd need to rewrite the input
> array which means we have to take a copy of the data as we probably
> shouldn't be changing the input data.
>
Yes, I am taking care of this. Probably my code will explain this :)
I have my patch ready. Let me send this..
> Indeed, looking at the drivers in mainline I can't actually see any of
> them which do block writes.
>
I am working on mfd/tps65910.c and function is:
static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
int bytes, void *src)
All your feedback will help me to improve my next two mfd/pmic drivers
which I am planning to upstream...
> * Unknown Key
> * 0x6E30FDDD
next prev parent reply other threads:[~2012-02-09 12:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 10:46 [PATCH V1 1/2] mfd: tps65910: use regmap for device register access Laxman Dewangan
2012-02-08 10:46 ` [PATCH V1 2/2] regulator: tps65910: Enable register caching of voltage controls Laxman Dewangan
2012-02-08 11:41 ` [PATCH V1 1/2] mfd: tps65910: use regmap for device register access Mark Brown
2012-02-08 12:15 ` Laxman Dewangan
2012-02-08 13:07 ` Mark Brown
2012-02-08 13:34 ` Laxman Dewangan
2012-02-08 13:58 ` Mark Brown
2012-02-09 5:03 ` Laxman Dewangan
2012-02-09 11:55 ` Mark Brown
2012-02-09 11:59 ` Laxman Dewangan [this message]
2012-02-09 12:03 ` Mark Brown
2012-02-09 12:09 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33B52A.5020900@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox