* [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
@ 2012-02-10 7:07 Mike Galbraith
2012-02-10 16:11 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Mike Galbraith @ 2012-02-10 7:07 UTC (permalink / raw)
To: LKML; +Cc: Greg Kroah-Hartman
usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
cripts/kconfig/conf --oldconfig Kconfig
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
Signed-off-by: Mike Galbraith <efault@gmx.de>
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 91413ca..b224959 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -547,6 +547,7 @@ config USB_WHCI_HCD
tristate "Wireless USB Host Controller Interface (WHCI) driver (EXPERIMENTAL)"
depends on EXPERIMENTAL
depends on PCI && USB
+ select UWB
select USB_WUSB
select UWB_WHCI
help
@@ -560,6 +561,7 @@ config USB_HWA_HCD
tristate "Host Wire Adapter (HWA) driver (EXPERIMENTAL)"
depends on EXPERIMENTAL
depends on USB
+ select UWB
select USB_WUSB
select UWB_HWA
help
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
2012-02-10 7:07 [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD Mike Galbraith
@ 2012-02-10 16:11 ` Randy Dunlap
2012-02-10 18:11 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2012-02-10 16:11 UTC (permalink / raw)
To: Mike Galbraith; +Cc: LKML, Greg Kroah-Hartman
On 02/09/2012 11:07 PM, Mike Galbraith wrote:
> usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
>
> cripts/kconfig/conf --oldconfig Kconfig
> warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
> warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
> warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
> warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on"
instead...
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 91413ca..b224959 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -547,6 +547,7 @@ config USB_WHCI_HCD
> tristate "Wireless USB Host Controller Interface (WHCI) driver (EXPERIMENTAL)"
> depends on EXPERIMENTAL
> depends on PCI && USB
> + select UWB
> select USB_WUSB
> select UWB_WHCI
> help
> @@ -560,6 +561,7 @@ config USB_HWA_HCD
> tristate "Host Wire Adapter (HWA) driver (EXPERIMENTAL)"
> depends on EXPERIMENTAL
> depends on USB
> + select UWB
> select USB_WUSB
> select UWB_HWA
> help
>
>
> --
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
2012-02-10 16:11 ` Randy Dunlap
@ 2012-02-10 18:11 ` Greg Kroah-Hartman
2012-02-11 5:43 ` Mike Galbraith
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2012-02-10 18:11 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Mike Galbraith, LKML
On Fri, Feb 10, 2012 at 08:11:26AM -0800, Randy Dunlap wrote:
> On 02/09/2012 11:07 PM, Mike Galbraith wrote:
> > usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
> >
> > cripts/kconfig/conf --oldconfig Kconfig
> > warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
> > warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
> > warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
> > warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
> >
> > Signed-off-by: Mike Galbraith <efault@gmx.de>
>
> I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on"
> instead...
Yes, this should all now be resolved, Mike can you verify this please?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
2012-02-10 18:11 ` Greg Kroah-Hartman
@ 2012-02-11 5:43 ` Mike Galbraith
2012-02-11 19:08 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Mike Galbraith @ 2012-02-11 5:43 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Randy Dunlap, LKML
On Fri, 2012-02-10 at 10:11 -0800, Greg Kroah-Hartman wrote:
> On Fri, Feb 10, 2012 at 08:11:26AM -0800, Randy Dunlap wrote:
> > On 02/09/2012 11:07 PM, Mike Galbraith wrote:
> > > usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
> > >
> > > cripts/kconfig/conf --oldconfig Kconfig
> > > warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
> > > warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
> > > warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
> > > warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
> > >
> > > Signed-off-by: Mike Galbraith <efault@gmx.de>
> >
> > I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on"
> > instead...
>
> Yes, this should all now be resolved, Mike can you verify this please?
Nah, Randy surely did, and it would be hard to mess it up ;-)
-Mike
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
2012-02-11 5:43 ` Mike Galbraith
@ 2012-02-11 19:08 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2012-02-11 19:08 UTC (permalink / raw)
To: Mike Galbraith; +Cc: Greg Kroah-Hartman, LKML
On 02/10/2012 09:43 PM, Mike Galbraith wrote:
> On Fri, 2012-02-10 at 10:11 -0800, Greg Kroah-Hartman wrote:
>> On Fri, Feb 10, 2012 at 08:11:26AM -0800, Randy Dunlap wrote:
>>> On 02/09/2012 11:07 PM, Mike Galbraith wrote:
>>>> usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD
>>>>
>>>> cripts/kconfig/conf --oldconfig Kconfig
>>>> warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
>>>> warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
>>>> warning: (USB_WHCI_HCD && USB_HWA_HCD) selects USB_WUSB which has unmet direct dependencies (USB_SUPPORT && EXPERIMENTAL && USB && PCI && UWB)
>>>> warning: (USB_WHCI_HCD) selects UWB_WHCI which has unmet direct dependencies (UWB && PCI)
>>>>
>>>> Signed-off-by: Mike Galbraith <efault@gmx.de>
>>>
>>> I have 2 patches in linux-next that fix the UWB/WUSB problems by using "depends on"
>>> instead...
>>
>> Yes, this should all now be resolved, Mike can you verify this please?
>
> Nah, Randy surely did, and it would be hard to mess it up ;-)
Hah. It took me two simple patches to get it right AFAIK. :(
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-11 19:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-10 7:07 [patch] usb: add missing Kconfig UWB select to USB_WHCI_HCD and USB_HWA_HCD Mike Galbraith
2012-02-10 16:11 ` Randy Dunlap
2012-02-10 18:11 ` Greg Kroah-Hartman
2012-02-11 5:43 ` Mike Galbraith
2012-02-11 19:08 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).