public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@ubuntu.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
	dm-devel@redhat.com, Karel Zak <kzak@redhat.com>,
	maxim.patlasov@gmail.com
Subject: Re: [PATCH 0/2] block: online resize of disk partitions
Date: Mon, 13 Feb 2012 16:34:54 -0500	[thread overview]
Message-ID: <4F3981FE.7090601@ubuntu.com> (raw)
In-Reply-To: <1329161438-12602-1-git-send-email-vgoyal@redhat.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/13/2012 2:30 PM, Vivek Goyal wrote:
> Hi,
> 
> Following patch adds support for online resizing of a partition.
> This patch is based on previously posted patches by Phillip Susi.
> 
> There are two patches. Out of which one is kernel patch and other
> one is util-linux patch to add support of a user space utility
> "resizepart" to allow resizing the partition.
> 
> This ioctl only resizes the partition size in kenrel and does not
> change the size on disk. A user needs to make sure that
> corresponding changes are made to disk data structures also using
> fdisk(or partx), if changes are to be retained across reboot.
> 
> I made some changes according to the feedback received last time.
> Following are changes since the version Phillip posted.
> 
> - RESIZE ioctl ignores the partition "start" and does not expect
> user to specify one. Caller needs to just specify "device",
> "partition number" and "size" of new partition.

I would prefer that the start argument not be left undefined.  I
checked it to make sure it was unchanged as a simple sanity check to
guard against user space being goofy, as well as to allow for the
possibility of extending the interface in the future to allow changing
the start as well as the length.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPOYH+AAoJEJrBOlT6nu75rvwIALjEMrUZPEvwYzH9MI9wHmGg
lZzeBTSalqEOWL/hM0Ge6o1Of1adjeEyB7riXi7Fbb4Z8U55oBkAyKcRD/fdm0EA
8SyfMnGnMqZjh6VthIZMw43HbNwHojXeu2ri4ygeUORMIrX8tmZLAePw6iuOWcX6
qxOZsJOz3CdoGy2yc362AuIQACKH6IfFimP81NH5uUA01DIawWpes3EuN+KcxOQP
hlIeixVPzlNrXuDY/m35xlXNaXcTUqTYFJ30vvVn0/MHylAbfCXKx6P19jvPHTt9
j0OyBNVnsb/BCKsbSW89lfHoVPMeYC6Kz2u8d1AX5byCxcYcznqclA6S93/UUms=
=ZABC
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2012-02-13 21:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 19:30 [PATCH 0/2] block: online resize of disk partitions Vivek Goyal
2012-02-13 19:30 ` [PATCH 1/2] block: add partition resize function to blkpg ioctl Vivek Goyal
2012-02-13 19:30 ` [PATCH 2/2] resizepart: Utility to resize a partition Vivek Goyal
2012-02-13 21:34 ` Phillip Susi [this message]
2012-02-13 21:50   ` [PATCH 0/2] block: online resize of disk partitions Vivek Goyal
2012-02-13 21:56     ` Vivek Goyal
2012-02-13 22:18     ` Phillip Susi
2012-02-13 22:24       ` Vivek Goyal
2012-02-14  1:24         ` Phillip Susi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3981FE.7090601@ubuntu.com \
    --to=psusi@ubuntu.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=kzak@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxim.patlasov@gmail.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox