public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] security: TOMOYO should clean policy files
@ 2012-02-14 21:06 Randy Dunlap
  2012-02-15 12:36 ` Tetsuo Handa
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2012-02-14 21:06 UTC (permalink / raw)
  To: Linux Kernel Mailing List
  Cc: Kentaro Takeda, Tetsuo Handa, tomoyo-dev-en, James Morris,
	Andrew Morton

From: Randy Dunlap <rdunlap@xenotime.net>

TOMOYO creates some empty/default policy files during build.
It should remove them during 'make clean'.

I noticed that they were not being removed because the
"Creating ..." messages always occurred a maximum of one time
during 25 randconfig builds, so it was sometimes using the
files from a previous build (which is not a problem, but
still, 'make clean' should remove them).

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Cc:	Kentaro Takeda <takedakn@nttdata.co.jp>
Cc:	Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc:	tomoyo-dev-en@lists.sourceforge.jp
---
 security/tomoyo/Makefile |    2 ++
 1 file changed, 2 insertions(+)

--- linux-next-20120214.orig/security/tomoyo/Makefile
+++ linux-next-20120214/security/tomoyo/Makefile
@@ -46,3 +46,5 @@ $(obj)/builtin-policy.h: $(obj)/policy/p
 	@mv $@.tmp $@
 
 $(obj)/common.o: $(obj)/builtin-policy.h
+
+clean-dirs := $(objtree)/security/tomoyo/policy/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] security: TOMOYO should clean policy files
  2012-02-14 21:06 [PATCH] security: TOMOYO should clean policy files Randy Dunlap
@ 2012-02-15 12:36 ` Tetsuo Handa
  0 siblings, 0 replies; 2+ messages in thread
From: Tetsuo Handa @ 2012-02-15 12:36 UTC (permalink / raw)
  To: rdunlap; +Cc: linux-kernel, takedakn, tomoyo-dev-en, jmorris, akpm

Randy Dunlap wrote:
> TOMOYO creates some empty/default policy files during build.
> It should remove them during 'make clean'.
> 
> I noticed that they were not being removed because the
> "Creating ..." messages always occurred a maximum of one time
> during 25 randconfig builds, so it was sometimes using the
> files from a previous build (which is not a problem, but
> still, 'make clean' should remove them).

Thank you. But I prefer current behavior.

The content of automatically generated files depends on neither kernel config
nor architecture. They are static contents which are used when a user did not
explicitly supply contents. Therefore, I think we don't need to delete them by
'make clean'.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-15 12:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-14 21:06 [PATCH] security: TOMOYO should clean policy files Randy Dunlap
2012-02-15 12:36 ` Tetsuo Handa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox