* [PATCH V5 2/2] regmap: add regmap_bulk_write() for register write
@ 2012-02-12 14:19 Laxman Dewangan
2012-02-14 22:13 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Laxman Dewangan @ 2012-02-12 14:19 UTC (permalink / raw)
To: broonie, gregkh, lars, linux-kernel; +Cc: linux-tegra, ldewangan
The bulk_write() supports the data transfer to multi
register which takes the data into cpu_endianness format
and does formatting of data to device format before
sending to device.
The transfer can be completed in single transfer or multiple
transfer based on data formatting.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Changes from V1:
- Change commit message.
- Byte swapping in input data packet.
Changes from V2:
- Remove formatting if val_byte is 1.
- Allocating proper size of memory for val_byte != 1
Changes from V3:
- Stylish fixes.
Changes from V4:
- Remove support for case when parse_val is not available.
drivers/base/regmap/regmap.c | 50 ++++++++++++++++++++++++++++++++++++++++++
include/linux/regmap.h | 2 +
2 files changed, 52 insertions(+), 0 deletions(-)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index ba92217..9eb0189 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -482,6 +482,56 @@ int regmap_raw_write(struct regmap *map, unsigned int reg,
}
EXPORT_SYMBOL_GPL(regmap_raw_write);
+/*
+ * regmap_bulk_write(): Write multiple registers to the device
+ *
+ * @map: Register map to write to
+ * @reg: First register to be write from
+ * @val: Block of data to be written, in native register size for device
+ * @val_count: Number of registers to write
+ *
+ * This function is intended to be used for writing a large block of
+ * data to be device either in single transfer or multiple transfer.
+ *
+ * A value of zero will be returned on success, a negative errno will
+ * be returned in error cases.
+ */
+int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val,
+ size_t val_count)
+{
+ int ret = 0, i;
+ size_t val_bytes = map->format.val_bytes;
+ void *wval;
+
+ if (!map->format.parse_val)
+ return -EINVAL;
+
+ mutex_lock(&map->lock);
+
+ /* No formatting is require if val_byte is 1 */
+ if (val_bytes == 1) {
+ wval = (void *)val;
+ } else {
+ wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
+ if (!wval) {
+ ret = -ENOMEM;
+ dev_err(map->dev, "Error in memory allocation\n");
+ goto out;
+ }
+ for (i = 0; i < val_count * val_bytes; i += val_bytes)
+ map->format.parse_val(wval + i);
+ }
+ ret = _regmap_raw_write(map, reg, wval, val_bytes * val_count);
+
+ if (val_bytes != 1)
+ kfree(wval);
+
+out:
+ mutex_unlock(&map->lock);
+ return ret;
+}
+EXPORT_SYMBOL_GPL(regmap_bulk_write);
+
static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
unsigned int val_len)
{
diff --git a/include/linux/regmap.h b/include/linux/regmap.h
index a6ed6e6..0925e24 100644
--- a/include/linux/regmap.h
+++ b/include/linux/regmap.h
@@ -135,6 +135,8 @@ int regmap_reinit_cache(struct regmap *map,
int regmap_write(struct regmap *map, unsigned int reg, unsigned int val);
int regmap_raw_write(struct regmap *map, unsigned int reg,
const void *val, size_t val_len);
+int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val,
+ size_t val_count);
int regmap_read(struct regmap *map, unsigned int reg, unsigned int *val);
int regmap_raw_read(struct regmap *map, unsigned int reg,
void *val, size_t val_len);
--
1.7.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V5 2/2] regmap: add regmap_bulk_write() for register write
2012-02-12 14:19 [PATCH V5 2/2] regmap: add regmap_bulk_write() for register write Laxman Dewangan
@ 2012-02-14 22:13 ` Mark Brown
2012-02-15 5:59 ` Laxman Dewangan
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-02-14 22:13 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: gregkh, lars, linux-kernel, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 624 bytes --]
On Sun, Feb 12, 2012 at 07:49:43PM +0530, Laxman Dewangan wrote:
> The bulk_write() supports the data transfer to multi
> register which takes the data into cpu_endianness format
> and does formatting of data to device format before
> sending to device.
> The transfer can be completed in single transfer or multiple
> transfer based on data formatting.
Applied, thanks. When posting patches you should only number things for
the patch series you're currently posting - this isn't patch 2/2, this
is a single isolated patch. The numbering is only there to help people
and tools figure out which order to apply things in.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V5 2/2] regmap: add regmap_bulk_write() for register write
2012-02-14 22:13 ` Mark Brown
@ 2012-02-15 5:59 ` Laxman Dewangan
0 siblings, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2012-02-15 5:59 UTC (permalink / raw)
To: Mark Brown
Cc: gregkh@linuxfoundation.org, lars@metafoo.de,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
On Wednesday 15 February 2012 03:43 AM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Sun, Feb 12, 2012 at 07:49:43PM +0530, Laxman Dewangan wrote:
>
> Applied, thanks. When posting patches you should only number things for
> the patch series you're currently posting - this isn't patch 2/2, this
> is a single isolated patch. The numbering is only there to help people
> and tools figure out which order to apply things in.
Thanks, I understand now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-15 6:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-12 14:19 [PATCH V5 2/2] regmap: add regmap_bulk_write() for register write Laxman Dewangan
2012-02-14 22:13 ` Mark Brown
2012-02-15 5:59 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox