public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 8/12] arch/sparc: remove references to cpu_*_map.
@ 2012-02-15  4:58 Rusty Russell
  2012-02-15  5:11 ` David Miller
  2012-02-15  9:22 ` Srivatsa S. Bhat
  0 siblings, 2 replies; 3+ messages in thread
From: Rusty Russell @ 2012-02-15  4:58 UTC (permalink / raw)
  To: David S. Miller, sparclinux; +Cc: linux-kernel

From: Rusty Russell <rusty@rustcorp.com.au>

This has been obsolescent for a while; time for the final push.

Also get rid of obsolescent first_cpu().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org
---
 arch/sparc/kernel/leon_kernel.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/sparc/kernel/leon_kernel.c b/arch/sparc/kernel/leon_kernel.c
--- a/arch/sparc/kernel/leon_kernel.c
+++ b/arch/sparc/kernel/leon_kernel.c
@@ -104,11 +104,11 @@ static int irq_choose_cpu(const struct c
 {
 	cpumask_t mask;
 
-	cpus_and(mask, cpu_online_map, *affinity);
-	if (cpus_equal(mask, cpu_online_map) || cpus_empty(mask))
+	cpumask_and(&mask, cpu_online_mask, affinity);
+	if (cpumask_equal(&mask, cpu_online_mask) || cpus_empty(mask))
 		return boot_cpu_id;
 	else
-		return first_cpu(mask);
+		return cpumask_first(&mask);
 }
 #else
 #define irq_choose_cpu(affinity) boot_cpu_id


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 8/12] arch/sparc: remove references to cpu_*_map.
  2012-02-15  4:58 [PATCH 8/12] arch/sparc: remove references to cpu_*_map Rusty Russell
@ 2012-02-15  5:11 ` David Miller
  2012-02-15  9:22 ` Srivatsa S. Bhat
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-02-15  5:11 UTC (permalink / raw)
  To: rusty; +Cc: sparclinux, linux-kernel

From: Rusty Russell <rusty@rustcorp.com.au>
Date: Wed, 15 Feb 2012 15:28:04 +1030

> From: Rusty Russell <rusty@rustcorp.com.au>
> 
> This has been obsolescent for a while; time for the final push.
> 
> Also get rid of obsolescent first_cpu().
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Acked-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 8/12] arch/sparc: remove references to cpu_*_map.
  2012-02-15  4:58 [PATCH 8/12] arch/sparc: remove references to cpu_*_map Rusty Russell
  2012-02-15  5:11 ` David Miller
@ 2012-02-15  9:22 ` Srivatsa S. Bhat
  1 sibling, 0 replies; 3+ messages in thread
From: Srivatsa S. Bhat @ 2012-02-15  9:22 UTC (permalink / raw)
  To: Rusty Russell
  Cc: David S. Miller, sparclinux, linux-kernel, Venkatesh Pallipadi,
	akpm@linux-foundation.org

On 02/15/2012 10:28 AM, Rusty Russell wrote:

> From: Rusty Russell <rusty@rustcorp.com.au>
> 
> This has been obsolescent for a while; time for the final push.
> 
> Also get rid of obsolescent first_cpu().
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: sparclinux@vger.kernel.org
> ---
>  arch/sparc/kernel/leon_kernel.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/sparc/kernel/leon_kernel.c b/arch/sparc/kernel/leon_kernel.c
> --- a/arch/sparc/kernel/leon_kernel.c
> +++ b/arch/sparc/kernel/leon_kernel.c
> @@ -104,11 +104,11 @@ static int irq_choose_cpu(const struct c
>  {
>  	cpumask_t mask;
>  
> -	cpus_and(mask, cpu_online_map, *affinity);
> -	if (cpus_equal(mask, cpu_online_map) || cpus_empty(mask))
> +	cpumask_and(&mask, cpu_online_mask, affinity);
> +	if (cpumask_equal(&mask, cpu_online_mask) || cpus_empty(mask))


You could even change that cpus_empty() to cpumask_empty(&mask)...
Either way, it is fine..

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-02-15  9:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-15  4:58 [PATCH 8/12] arch/sparc: remove references to cpu_*_map Rusty Russell
2012-02-15  5:11 ` David Miller
2012-02-15  9:22 ` Srivatsa S. Bhat

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox