public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Marcos Paulo de Souza <marcos.mage@gmail.com>
Cc: lenb@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/idle/intel_idle.c: Fix confusing code identation
Date: Fri, 17 Feb 2012 14:27:39 +0530	[thread overview]
Message-ID: <4F3E1683.8040703@linux.vnet.ibm.com> (raw)
In-Reply-To: <1329468198-5887-1-git-send-email-marcos.mage@gmail.com>

On 02/17/2012 02:13 PM, Marcos Paulo de Souza wrote:

> Suggested-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
> ---


Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

[ A small commit message wouldn't hurt though :-) ]

Regards,
Srivatsa S. Bhat

>  drivers/idle/intel_idle.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 54ab97b..5e71b98 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -495,8 +495,7 @@ int intel_idle_cpu_init(int cpu)
>  		int num_substates;
> 
>  		if (cstate > max_cstate) {
> -			printk(PREFIX "max_cstate %d reached\n",
> -			       max_cstate);
> +			printk(PREFIX "max_cstate %d reached\n", max_cstate);
>  			break;
>  		}
> 
> @@ -512,8 +511,9 @@ int intel_idle_cpu_init(int cpu)
>  		dev->states_usage[dev->state_count].driver_data =
>  			(void *)get_driver_data(cstate);
> 
> -			dev->state_count += 1;
> -		}
> +		dev->state_count += 1;
> +	}
> +
>  	dev->cpu = cpu;
> 
>  	if (cpuidle_register_device(dev)) {


      reply	other threads:[~2012-02-17  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17  8:43 [PATCH] drivers/idle/intel_idle.c: Fix confusing code identation Marcos Paulo de Souza
2012-02-17  8:57 ` Srivatsa S. Bhat [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3E1683.8040703@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=marcos.mage@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox