From: Michael Cree <mcree@orcon.net.nz>
To: Jim Faulkner <jfaulkne@ccs.neu.edu>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, gregkh@linuxfoundation.org,
rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com,
torvalds@linux-foundation.org, jay.estabrook@gmail.com
Subject: Re: [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y
Date: Sun, 19 Feb 2012 11:29:34 +1300 [thread overview]
Message-ID: <4F40264E.6050602@orcon.net.nz> (raw)
In-Reply-To: <20120218212431.GA25058@alumni-linux.ccs.neu.edu>
On 19/02/12 10:24, Jim Faulkner wrote:
> Linux 3.2.6 fails to modpost on my alpha machine when
> CONFIG_ALPHA_TSUNAMI=y. Linux 3.3-rc3 does not appear to have a fix for
> this bug, so is likely also affected. I've attached a patch which fixes
> this issue. I have tested this patch on Linux 3.2.6 successfully, and
> the patch also applies cleanly to Linux 3.3-rc3.
> diff -uNr linux-3.3-rc3/arch/alpha/kernel/core_tsunami.c linux-3.3-rc3.patched/arch/alpha/kernel/core_tsunami.c
> --- linux-3.3-rc3/arch/alpha/kernel/core_tsunami.c 2012-02-08 22:21:53.000000000 -0500
> +++ linux-3.3-rc3.patched/arch/alpha/kernel/core_tsunami.c 2012-02-18 16:07:12.859977887 -0500
> @@ -11,6 +11,7 @@
> #include <asm/core_tsunami.h>
> #undef __EXTERN_INLINE
>
> +#include <linux/module.h>
Wouldn't <linux/exports.h> be better? I seem to recall that this was a
problem with EXPORT_SYMBOL not being defined and I see my own personal
fix (which I had completely forgotten to send upstream) was to include
<linux/exports.h>
> #include <linux/types.h>
> #include <linux/pci.h>
> #include <linux/sched.h>
Cheers
Michael.
next prev parent reply other threads:[~2012-02-18 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 0:35 Linux 3.2 fails to modpost on alpha arch: tsunami_ioportmap undefined Jim Faulkner
2012-02-18 21:24 ` [PATCH] fix modpost when CONFIG_ALPHA_TSUNAMI=y Jim Faulkner
2012-02-18 22:29 ` Michael Cree [this message]
2012-02-18 22:39 ` Jim Faulkner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F40264E.6050602@orcon.net.nz \
--to=mcree@orcon.net.nz \
--cc=gregkh@linuxfoundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=jay.estabrook@gmail.com \
--cc=jfaulkne@ccs.neu.edu \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox