public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH V1] mfd: tps65910: Initialize irq platform data properly
Date: Sun, 19 Feb 2012 13:04:07 +0530	[thread overview]
Message-ID: <4F40A5EF.4080909@nvidia.com> (raw)
In-Reply-To: <4F2A95F2.9000006@nvidia.com>

Hi Samuel,
Can you please review this patch? Without this change, the device is 
corrupting other irq registration because it tries to register  wrong irqs.

Thanks,
Laxman

On Thursday 02 February 2012 07:26 PM, Laxman Dewangan wrote:
> On Wednesday 18 January 2012 08:19 PM, Laxman Dewangan wrote:
>> irq_base of the tps65910 irq platform data should be
>> initialized with the board provided irq_base data.
>>
>> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
>> ---
>>    drivers/mfd/tps65910.c |    2 +-
>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
>> index c1da84b..8517481 100644
>> --- a/drivers/mfd/tps65910.c
>> +++ b/drivers/mfd/tps65910.c
>> @@ -168,7 +168,7 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
>>    		goto err;
>>
>>    	init_data->irq = pmic_plat_data->irq;
>> -	init_data->irq_base = pmic_plat_data->irq;
>> +	init_data->irq_base = pmic_plat_data->irq_base;
>>
>>    	tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
>>
> Hi Samuel,
> Any feedback on this patch?
>
> Thanks,
> Laxman
>
>


  reply	other threads:[~2012-02-19  7:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 14:49 [PATCH V1] mfd: tps65910: Initialize irq platform data properly Laxman Dewangan
2012-02-02 13:56 ` Laxman Dewangan
2012-02-19  7:34   ` Laxman Dewangan [this message]
2012-02-20 16:45 ` Samuel Ortiz
2012-02-21  5:38   ` Laxman Dewangan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F40A5EF.4080909@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox