From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
thomas@m3y3r.de, raven@themaw.net, linux-kernel@vger.kernel.org
Subject: Re: Linux 3.3-rc4
Date: Mon, 20 Feb 2012 20:22:00 -0800 [thread overview]
Message-ID: <4F431BE8.1030201@zytor.com> (raw)
In-Reply-To: <CA+55aFwqChUmmDfoYX7HRUUZg5s7nBOh834=g+7avj=yc42gGg@mail.gmail.com>
On 02/19/2012 12:02 PM, Linus Torvalds wrote:
> On Sun, Feb 19, 2012 at 11:49 AM, David Miller <davem@davemloft.net> wrote:
>>
>> A real shame, this should have used "__aligned_u64" from the
>> beginning.
>
> I agree. Sadly, this is exactly the kind of thing that is *really*
> easy to overlook, and once it is overlooked we're screwed because
> fixing it just breaks the native 32-bit case.
>
I'm starting to think we should compile the kernel with -Wpadded by
default (currently it's only done at "warning level 3", which I doubt
anyone ever uses, especially since that also includes -Wpacked which is
an actively toxic warning) and force people to add explicit padding
where it needs to go, if necessary. Unfortunately even that doesn't
guarantee compatibility with userspace, but it's at least something.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-02-21 4:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 0:27 Linux 3.3-rc4 Linus Torvalds
2012-02-19 13:42 ` Thomas Meyer
2012-02-19 18:45 ` Linus Torvalds
2012-02-19 19:49 ` David Miller
2012-02-19 20:02 ` Linus Torvalds
2012-02-20 3:28 ` Ian Kent
2012-02-21 3:29 ` Ian Kent
2012-02-21 3:38 ` Linus Torvalds
2012-02-21 4:02 ` Ian Kent
2012-02-21 4:17 ` Linus Torvalds
2012-02-21 4:52 ` Ian Kent
2012-02-21 5:06 ` Linus Torvalds
2012-02-21 5:21 ` Linus Torvalds
2012-02-21 5:27 ` H. Peter Anvin
2012-02-21 5:28 ` H. Peter Anvin
2012-02-21 5:32 ` Linus Torvalds
2012-02-21 5:39 ` Ian Kent
2012-02-21 4:18 ` H. Peter Anvin
2012-02-21 4:22 ` H. Peter Anvin [this message]
2012-02-21 13:03 ` Alan Cox
2012-02-21 18:26 ` Use gcc to check exported files [Was: Linux 3.3-rc4] Sam Ravnborg
2012-02-21 18:58 ` Linux 3.3-rc4 Thomas Meyer
2012-02-21 22:07 ` Linus Torvalds
2012-02-21 22:43 ` Linus Torvalds
2012-02-21 23:10 ` Eric Dumazet
2012-02-21 23:19 ` Linus Torvalds
2012-02-24 10:39 ` Jiri Kosina
2012-02-24 16:52 ` Linus Torvalds
2012-02-24 18:01 ` Jiri Kosina
2012-02-24 18:21 ` Linus Torvalds
2012-02-29 8:38 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F431BE8.1030201@zytor.com \
--to=hpa@zytor.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox