Re: RAS trace event proto

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 21-02-2012 12:59, Borislav Petkov escreveu:
> On Tue, Feb 21, 2012 at 09:48:18AM -0500, Steven Rostedt wrote:
>> On Tue, 2012-02-21 at 15:12 +0100, Borislav Petkov wrote:
>>
>>>> Also, folding everything into just one string prevents (or make hard) the usage of
>>>> the perf filters, for example, to filter only the errors at the memory controller 1.
>>>
>>> Huh, because you can't grep through the trace anymore...?
>>>
>>
>> I believe Mauro is talking about the tracing filters used by both perf
>> and ftrace that lets you ignore trace events when the contents of the
>> event does not match the filter. This is filtering out events before
>> they go to the buffer.

Yes, that's what I'm talking about.

Another advantage of using separate fields for the silkscreen label and for
the additional details is that the userspace program that it is displaying
it (trace-cmd or whatever) could have different profiles to either display
just the error message and the silkscreen label or to print the entire error
message.

> Oh ok, in that case we could filter the errors - if needed - before they
> get even reported. I say "if needed" because normally we want to collect
> all hw errors in the trace, IMHO.