From: David Ahern <dsahern@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] perf tools: Fix ordering with unstable tsc
Date: Wed, 22 Feb 2012 08:39:49 -0700 [thread overview]
Message-ID: <4F450C45.9070405@gmail.com> (raw)
In-Reply-To: <CABPqkBRDLrK=GvXWTZob_EQ2dqnWJg5GeWMYFj0N5t8z265Y9Q@mail.gmail.com>
On 2/22/12 8:35 AM, Stephane Eranian wrote:
>> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>> index 302d49a..1c8eb4b 100644
>> --- a/tools/perf/util/evsel.c
>> +++ b/tools/perf/util/evsel.c
>> @@ -119,9 +119,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct perf_record_opts *opts)
>> if (opts->raw_samples) {
>> attr->sample_type |= PERF_SAMPLE_TIME;
>> attr->sample_type |= PERF_SAMPLE_RAW;
>> - attr->sample_type |= PERF_SAMPLE_CPU;
>> }
>>
> I don't get this bit here. You may want CPU information when capturing
> in raw + per-thread mode.
TIME is added to sample_type for raw samples and then CPU gets added below.
>
>
>> + /* Need to know the CPU for tools that need to order events */
>> + if (attr->sample_type& PERF_SAMPLE_TIME)
>> + attr->sample_type |= PERF_SAMPLE_CPU;
>> +
David
next prev parent reply other threads:[~2012-02-22 15:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 13:25 [BUG] perf: perf sched warning possibly due to clock granularity on AMD Stephane Eranian
2012-02-06 14:26 ` Peter Zijlstra
2012-02-06 14:31 ` Stephane Eranian
2012-02-06 17:17 ` Arnaldo Carvalho de Melo
2012-02-06 15:34 ` Borislav Petkov
2012-02-06 16:37 ` Peter Zijlstra
2012-02-06 16:46 ` Borislav Petkov
2012-02-06 16:54 ` Peter Zijlstra
2012-02-06 20:27 ` Borislav Petkov
2012-02-06 20:31 ` Peter Zijlstra
2012-02-06 20:37 ` Borislav Petkov
2012-02-06 21:19 ` Venki Pallipadi
2012-02-07 7:51 ` Peter Zijlstra
2012-02-07 8:32 ` Ingo Molnar
2012-02-07 9:06 ` Borislav Petkov
2012-02-07 9:50 ` Ingo Molnar
2012-02-07 12:08 ` [PATCH] x86, AMD: Set sched_clock_stable Borislav Petkov
2012-02-15 15:30 ` Peter Zijlstra
2012-02-07 19:43 ` [tip:perf/core] x86/sched/perf/AMD: " tip-bot for Borislav Petkov
2012-02-08 15:07 ` [BUG] perf: perf sched warning possibly due to clock granularity on AMD Frederic Weisbecker
2012-02-08 15:10 ` Stephane Eranian
2012-02-08 15:22 ` Frederic Weisbecker
2012-02-08 15:23 ` Stephane Eranian
2012-02-18 16:50 ` [PATCH] perf tools: Fix ordering with unstable tsc Frederic Weisbecker
2012-02-22 15:35 ` Stephane Eranian
2012-02-22 15:39 ` David Ahern [this message]
2012-03-05 18:43 ` Frederic Weisbecker
2012-03-14 19:55 ` Arnaldo Carvalho de Melo
2012-03-14 20:07 ` David Ahern
2012-03-22 0:10 ` Frederic Weisbecker
2012-03-22 15:28 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2012-10-05 15:22 David Ahern
2012-10-06 15:17 ` David Ahern
2012-10-06 15:33 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F450C45.9070405@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox