From: "Andreas Bießmann" <andreas@biessmann.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Andreas Bießmann" <andreas@biessmann.de>,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
"Jochen Friedrich" <jochen@scram.de>,
"Samuel Ortiz" <sameo@linux.intel.com>,
"K. Y. Srinivasan" <kys@microsoft.com>
Subject: Re: [PATCH] mod/file2alias: make modpost compile on darwin again
Date: Thu, 23 Feb 2012 07:28:41 +0100 [thread overview]
Message-ID: <4F45DC99.1050405@biessmann.de> (raw)
In-Reply-To: <874nui5uv2.fsf@rustcorp.com.au>
On 23.02.12 00:08, Rusty Russell wrote:
> On Wed, 22 Feb 2012 22:55:35 +0100, Andreas Bießmann <andreas@biessmann.de> wrote:
>> commit e49ce14150c64b29a8dd211df785576fa19a9858 breaks cross compiling
>> the linux kernel on darwin hosts.
>> This fix introduce some minimal glue to adopt linker section handling
>> for darwin hosts.
>
> Really?
Yes.
> Yes, I assumed an ELF host. There's a portable way of doing this, but
> it's damn ugly (see http://ccodearchive.net/info/autodata.html).
I stumbled over some other code snippet [1] when searching for a solution.
> Oh, and checkpatch.pl is wrong, the code was fine.
Sorry for that. I was running checkpatch.pl as dutiful patch submitter
and that complained. Should I provide another version with 'checkpatch'
adoptions changed back?
> If noone has strong opinions about this, I'll apply it.
Would be great. I guess this is a rare case (cross compiling on darwin
host) but at least I and some of my colleagues do it from time to time.
Andreas
--
[1]
http://google-perftools.googlecode.com/svn/!svn/bc/48/trunk/src/base/basictypes.h
next prev parent reply other threads:[~2012-02-23 6:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 21:55 [PATCH] mod/file2alias: make modpost compile on darwin again Andreas Bießmann
2012-02-22 23:08 ` Rusty Russell
2012-02-23 6:28 ` Andreas Bießmann [this message]
2012-02-24 4:04 ` Rusty Russell
2012-02-24 7:23 ` [PATCH v2] " Andreas Bießmann
2012-02-25 3:51 ` Rusty Russell
2012-02-26 16:27 ` Bernhard Walle
2012-02-27 0:03 ` [PULL] modpost fix for cross-compiling Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F45DC99.1050405@biessmann.de \
--to=andreas@biessmann.de \
--cc=gregkh@linuxfoundation.org \
--cc=jochen@scram.de \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).