From: Eugeni Dodonov <eugeni.dodonov@intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Dave Airlie <airlied@redhat.com>,
Alex Deucher <alexdeucher@gmail.com>
Subject: Re: [PATCH] drm: Reduce the number of retries whilst reading EDIDs
Date: Thu, 23 Feb 2012 19:36:41 -0200 [thread overview]
Message-ID: <4F46B169.1030307@intel.com> (raw)
In-Reply-To: <CA+55aFyAUgY5BBLA+eVF4bFTFkooxQneKE-0BWy1nrjUni=vxg@mail.gmail.com>
On 02/23/2012 06:15 PM, Linus Torvalds wrote:
> On Thu, Feb 23, 2012 at 11:52 AM, Chris Wilson<chris@chris-wilson.co.uk> wrote:
>>
>> i2c retries if sees an EGAIN, drm_do_probe_ddc_edid retries until it
>> gets a result and *then* drm_do_get_edid retries until it gets a result
>> it is happy with. All in all, that is a lot of processor intensive
>> looping in cases where we do not expect and cannot get valid data - for
>> example on Intel with disconnected hardware we will busy-spin until we
>> hit the i2c timeout. This is then repeated for every connector when
>> querying the current status of outputs.
>
> Sadly, this doesn't seem to make any difference to my case. My xrandr
> stays at 0.555s even with this patch.
Perhaps a stupid question, but does you tree has
http://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next&id=9292f37e1f5c79400254dca46f83313488093825
from Dave's drm-next?
If it has, it would be the 1st time that I see xrandr take longer than
.5s with that patch on an Intel GPU. We even added a check for this into
intel-gpu-tools to warn us if any machine takes that long, and none had
hit it so far. So if this is the case here, there is something Mac
Mini-specific indeed to investigate.
-Eugeni
next prev parent reply other threads:[~2012-02-23 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:30 responsiveness: newer kernels causing lagging and blocking Stephan Bärwolf
2012-02-23 17:12 ` Linus Torvalds
2012-02-23 17:26 ` Stephan Bärwolf
2012-02-23 17:21 ` Chris Wilson
2012-02-23 17:29 ` Linus Torvalds
2012-02-23 17:31 ` Dave Airlie
2012-02-23 18:15 ` Linus Torvalds
2012-02-23 19:52 ` [PATCH] drm: Reduce the number of retries whilst reading EDIDs Chris Wilson
2012-02-23 20:15 ` Linus Torvalds
2012-02-23 20:36 ` Linus Torvalds
2012-02-23 21:36 ` Eugeni Dodonov [this message]
2012-02-23 21:40 ` Linus Torvalds
2012-02-24 15:17 ` Adam Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F46B169.1030307@intel.com \
--to=eugeni.dodonov@intel.com \
--cc=airlied@redhat.com \
--cc=alexdeucher@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox