From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757551Ab2BXPuC (ORCPT ); Fri, 24 Feb 2012 10:50:02 -0500 Received: from mail-pw0-f46.google.com ([209.85.160.46]:49145 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754481Ab2BXPuA (ORCPT ); Fri, 24 Feb 2012 10:50:00 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of dsahern@gmail.com designates 10.68.212.3 as permitted sender) smtp.mail=dsahern@gmail.com; dkim=pass header.i=dsahern@gmail.com Message-ID: <4F47B1A3.6050503@gmail.com> Date: Fri, 24 Feb 2012 08:49:55 -0700 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Stephane Eranian CC: linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, mingo@elte.hu, ravitillo@lbl.gov, khandual@linux.vnet.ibm.com, asharma@fb.com, robert.richter@amd.com, ming.m.lin@intel.com, vweaver1@eecs.utk.edu, andi@firstfloor.org Subject: Re: [PATCH] perf report: auto-detect branch stack sampling mode References: <20120224094048.GA7952@quad> <4F47ABAD.9080408@gmail.com> <4F47AD6A.6080609@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/24/12 8:40 AM, Stephane Eranian wrote: > No, I don't. Read the code carefully. The for loop sets all known feature bits. > Then, the ones not necessary or unused are turned off individually. Ok, I see now. The __set_feat loop is earlier in builtin-record.c, not the util code. David