public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: "\"Meng Zhang (张萌)\"" <Meng.Zhang@mediatek.com>
Cc: "smurf@smurf.noris.de" <smurf@smurf.noris.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces
Date: Mon, 27 Feb 2012 15:06:37 +0400	[thread overview]
Message-ID: <4F4B63BD.6070602@mvista.com> (raw)
In-Reply-To: <0D3EFCAF29FAA54FB91286E54DF1085C2304850460@MTKMBS30.mediatek.inc>

Hello.

On 27-02-2012 8:11, Meng Zhang (张萌) wrote:

> 1. To declare the product IDs in option.c
> 2. Please pull from
> 	git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>     to get these changes

    This patch is not yet there. :-)

> Signed-off-by: Meng Zhang<meng.zhang@mediatek.com>
> ---------------------------------------------------------------------------------------

    This line is not needed. If you want a sperator, use --- instead.

> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index b54afce..7069f9d 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -484,6 +484,9 @@ static void option_instat_callback(struct urb *urb);
>   #define LG_VENDOR_ID                           0x1004
>   #define LG_PRODUCT_L02C                                0x618f
>
> +/* MediaTek products */
> +#define MEDIATEK_VENDOR_ID                     0x0e8d
> +
>   /* some devices interfaces need special handling due to a number of reasons */
>   enum option_blacklist_reason {
>                  OPTION_BLACKLIST_NONE = 0,
> @@ -1198,6 +1201,10 @@ static const struct usb_device_id option_ids[] = {
>          { USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) },
>          { USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 0xff, 0xff, 0xff) },
>          { USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C modem */
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x00, 0x00) },
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x02, 0x01) },
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x00, 0x00) },
> +       { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x02, 0x01) },        /* MediaTek MT6276M modem&  app port */

    All tabs in the patch were converted to spaces.

WBR, Sergei

  reply	other threads:[~2012-02-27 11:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27  4:11 [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces Meng Zhang (张萌)
2012-02-27 11:06 ` Sergei Shtylyov [this message]
2012-02-27 11:57   ` Meng Zhang (张萌)
  -- strict thread matches above, loose matches on Subject: below --
2012-02-27  4:57 Meng Zhang
2012-02-24  8:04 meng zhang
2012-02-24  6:41 meng zhang
2012-02-24 11:31 ` Sergei Shtylyov
2012-02-24 15:40 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4B63BD.6070602@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=Meng.Zhang@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=smurf@smurf.noris.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox