From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753839Ab2B0Lxp (ORCPT ); Mon, 27 Feb 2012 06:53:45 -0500 Received: from multi.imgtec.com ([194.200.65.239]:47780 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089Ab2B0Lxo (ORCPT ); Mon, 27 Feb 2012 06:53:44 -0500 Message-ID: <4F4B6EC5.1070806@imgtec.com> Date: Mon, 27 Feb 2012 11:53:41 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.10 MIME-Version: 1.0 To: Mauro Carvalho Chehab , Paul Gortmaker , , linux-kernel Subject: [RESEND] [PATCH] media: ir-sony-decoder: 15bit function decode fix Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Feb 2012 11:53:42.0033 (UTC) FILETIME=[7372F010:01CCF546] X-SEF-Processed: 7_3_0_01181__2012_02_27_11_53_42 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The raw Sony IR decoder decodes 15bit messages slightly incorrectly. To decode the function number, it shifts the bits right by 7 so that the function is in bits 7:1, masks with 0xFD (0b11111101), and does an 8 bit reverse so it ends up in bits 6:0. The mask should be 0xFE to correspond with bits 7:1 (0b11111110). The old mask had the effect of dropping the MSB of the function number from bit 6, and leaving the LSB of the device number in bit 7. Signed-off-by: James Hogan --- (note, i don't have a 15bit sony remote to test this with, but i'm pretty confident of it's correctness based on this: http://picprojects.org.uk/projects/sirc/sonysirc.pdf ) drivers/media/rc/ir-sony-decoder.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/rc/ir-sony-decoder.c b/drivers/media/rc/ir-sony-decoder.c index d5e2b50..dab98b3 100644 --- a/drivers/media/rc/ir-sony-decoder.c +++ b/drivers/media/rc/ir-sony-decoder.c @@ -130,7 +130,7 @@ static int ir_sony_decode(struct rc_dev *dev, struct ir_raw_event ev) case 15: device = bitrev8((data->bits >> 0) & 0xFF); subdevice = 0; - function = bitrev8((data->bits >> 7) & 0xFD); + function = bitrev8((data->bits >> 7) & 0xFE); break; case 20: device = bitrev8((data->bits >> 5) & 0xF8); -- 1.7.2.3