From: Roland Stigge <stigge@antcom.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH v3] ARM: LPC32xx: Ethernet support
Date: Mon, 27 Feb 2012 23:04:02 +0100 [thread overview]
Message-ID: <4F4BFDD2.8060007@antcom.de> (raw)
In-Reply-To: <20120227180814.GB21386@pengutronix.de>
On 27/02/12 19:08, Wolfram Sang wrote:
> On Mon, Feb 27, 2012 at 06:46:02PM +0100, Roland Stigge wrote:
>> This patch adds ethernet support to the LPC32xx ARM architecture.
>> The actual driver in drivers/net is contained in a separate
>> patch.
>>
>> Signed-off-by: Roland Stigge <stigge@antcom.de>
>>
>> ---
>
> Please add below this dashed line what changed since the last
> version. This makes reviewing easier.
OK, will do next time.
For the driver, some style fixes were applied, and the cmdline
"ethaddr" was removed, relying on the bootloader to set it correctly
(and it actually does, it actually needs to prepare TFTP booting).
The platform-support patch just adjusted to the small driver change:
driver name adjustment ("lpc-eth") for consistency.
Roland
next prev parent reply other threads:[~2012-02-27 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 17:46 [PATCH v3] ARM: LPC32xx: Ethernet support Roland Stigge
2012-02-27 18:08 ` Wolfram Sang
2012-02-27 22:04 ` Roland Stigge [this message]
2012-02-27 23:10 ` Kevin Wells
2012-02-28 6:38 ` Arnd Bergmann
2012-02-27 18:17 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BFDD2.8060007@antcom.de \
--to=stigge@antcom.de \
--cc=arnd@arndb.de \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox