From: David Daney <ddaney.cavm@gmail.com>
To: Venkatesh Pallipadi <venki@google.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Tony Luck <tony.luck@gmail.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Mike Travis <travis@sgi.com>,
"Paul E. McKenney" <paul.mckenney@linaro.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org, Richard Kuo <rkuo@codeaurora.org>,
linux-hexagon@vger.kernel.org, linux-mips@linux-mips.org,
Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map
Date: Mon, 27 Feb 2012 14:19:42 -0800 [thread overview]
Message-ID: <4F4C017E.5040200@gmail.com> (raw)
In-Reply-To: <1329259784-20592-3-git-send-email-venki@google.com>
On 02/14/2012 02:49 PM, Venkatesh Pallipadi wrote:
> Use set_cpu_* and init_cpu_* variants instead.
>
> Signed-off-by: Venkatesh Pallipadi<venki@google.com>
I came up with the same thing, so...
Acked-by: David Daney <david.daney@cavium.com>
Ralf: If you too were to Acknowledge the patch, we might get it merged.
David Daney
> ---
> arch/mips/cavium-octeon/smp.c | 2 +-
> arch/mips/kernel/smp.c | 4 ++--
> arch/mips/netlogic/xlr/smp.c | 4 ++--
> arch/mips/pmc-sierra/yosemite/smp.c | 4 ++--
> arch/mips/sgi-ip27/ip27-smp.c | 2 +-
> arch/mips/sibyte/bcm1480/smp.c | 5 ++---
> arch/mips/sibyte/sb1250/smp.c | 5 ++---
> 7 files changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index efcfff4..5cce09c 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -268,7 +268,7 @@ static int octeon_cpu_disable(void)
>
> spin_lock(&smp_reserve_lock);
>
> - cpu_clear(cpu, cpu_online_map);
> + set_cpu_online(cpu, false);
> cpu_clear(cpu, cpu_callin_map);
> local_irq_disable();
> fixup_irqs();
> diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
> index 32c1e95..28777ff 100644
> --- a/arch/mips/kernel/smp.c
> +++ b/arch/mips/kernel/smp.c
> @@ -148,7 +148,7 @@ static void stop_this_cpu(void *dummy)
> /*
> * Remove this CPU:
> */
> - cpu_clear(smp_processor_id(), cpu_online_map);
> + set_cpu_online(smp_processor_id(), false);
> for (;;) {
> if (cpu_wait)
> (*cpu_wait)(); /* Wait if available. */
> @@ -248,7 +248,7 @@ int __cpuinit __cpu_up(unsigned int cpu)
> while (!cpu_isset(cpu, cpu_callin_map))
> udelay(100);
>
> - cpu_set(cpu, cpu_online_map);
> + set_cpu_online(cpu, true);
>
> return 0;
> }
> diff --git a/arch/mips/netlogic/xlr/smp.c b/arch/mips/netlogic/xlr/smp.c
> index 080284d..8084221 100644
> --- a/arch/mips/netlogic/xlr/smp.c
> +++ b/arch/mips/netlogic/xlr/smp.c
> @@ -154,7 +154,7 @@ void __init nlm_smp_setup(void)
> cpu_set(boot_cpu, phys_cpu_present_map);
> __cpu_number_map[boot_cpu] = 0;
> __cpu_logical_map[0] = boot_cpu;
> - cpu_set(0, cpu_possible_map);
> + set_cpu_possible(0, true);
>
> num_cpus = 1;
> for (i = 0; i< NR_CPUS; i++) {
> @@ -166,7 +166,7 @@ void __init nlm_smp_setup(void)
> cpu_set(i, phys_cpu_present_map);
> __cpu_number_map[i] = num_cpus;
> __cpu_logical_map[num_cpus] = i;
> - cpu_set(num_cpus, cpu_possible_map);
> + set_cpu_possible(num_cpus, true);
> ++num_cpus;
> }
> }
> diff --git a/arch/mips/pmc-sierra/yosemite/smp.c b/arch/mips/pmc-sierra/yosemite/smp.c
> index 2608752..b2b23eb 100644
> --- a/arch/mips/pmc-sierra/yosemite/smp.c
> +++ b/arch/mips/pmc-sierra/yosemite/smp.c
> @@ -155,10 +155,10 @@ static void __init yos_smp_setup(void)
> {
> int i;
>
> - cpus_clear(cpu_possible_map);
> + init_cpu_possible(cpumask_of(0));
>
> for (i = 0; i< 2; i++) {
> - cpu_set(i, cpu_possible_map);
> + set_cpu_possible(i, true);
> __cpu_number_map[i] = i;
> __cpu_logical_map[i] = i;
> }
> diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c
> index c6851df..735b43b 100644
> --- a/arch/mips/sgi-ip27/ip27-smp.c
> +++ b/arch/mips/sgi-ip27/ip27-smp.c
> @@ -76,7 +76,7 @@ static int do_cpumask(cnodeid_t cnode, nasid_t nasid, int highest)
> /* Only let it join in if it's marked enabled */
> if ((acpu->cpu_info.flags& KLINFO_ENABLE)&&
> (tot_cpus_found != NR_CPUS)) {
> - cpu_set(cpuid, cpu_possible_map);
> + set_cpu_possible(cpuid, true);
> alloc_cpupda(cpuid, tot_cpus_found);
> cpus_found++;
> tot_cpus_found++;
> diff --git a/arch/mips/sibyte/bcm1480/smp.c b/arch/mips/sibyte/bcm1480/smp.c
> index d667875..63d2211 100644
> --- a/arch/mips/sibyte/bcm1480/smp.c
> +++ b/arch/mips/sibyte/bcm1480/smp.c
> @@ -147,14 +147,13 @@ static void __init bcm1480_smp_setup(void)
> {
> int i, num;
>
> - cpus_clear(cpu_possible_map);
> - cpu_set(0, cpu_possible_map);
> + init_cpu_possible(cpumask_of(0));
> __cpu_number_map[0] = 0;
> __cpu_logical_map[0] = 0;
>
> for (i = 1, num = 0; i< NR_CPUS; i++) {
> if (cfe_cpu_stop(i) == 0) {
> - cpu_set(i, cpu_possible_map);
> + set_cpu_possible(i, true);
> __cpu_number_map[i] = ++num;
> __cpu_logical_map[num] = i;
> }
> diff --git a/arch/mips/sibyte/sb1250/smp.c b/arch/mips/sibyte/sb1250/smp.c
> index 38e7f6b..77f0df5 100644
> --- a/arch/mips/sibyte/sb1250/smp.c
> +++ b/arch/mips/sibyte/sb1250/smp.c
> @@ -135,14 +135,13 @@ static void __init sb1250_smp_setup(void)
> {
> int i, num;
>
> - cpus_clear(cpu_possible_map);
> - cpu_set(0, cpu_possible_map);
> + init_cpu_possible(cpumask_of(0));
> __cpu_number_map[0] = 0;
> __cpu_logical_map[0] = 0;
>
> for (i = 1, num = 0; i< NR_CPUS; i++) {
> if (cfe_cpu_stop(i) == 0) {
> - cpu_set(i, cpu_possible_map);
> + set_cpu_possible(i, true);
> __cpu_number_map[i] = ++num;
> __cpu_logical_map[num] = i;
> }
next prev parent reply other threads:[~2012-02-27 22:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 2:07 [PATCH] Avoid mask based num_possible_cpus and num_online_cpus Venkatesh Pallipadi
2012-01-18 5:55 ` KOSAKI Motohiro
2012-01-18 18:52 ` Venki Pallipadi
2012-01-18 19:20 ` KOSAKI Motohiro
2012-01-19 20:01 ` Venkatesh Pallipadi
2012-01-19 20:40 ` KOSAKI Motohiro
2012-01-21 1:01 ` Venki Pallipadi
2012-01-19 20:43 ` Srivatsa S. Bhat
2012-01-20 23:09 ` Venki Pallipadi
2012-01-20 23:45 ` KOSAKI Motohiro
2012-01-20 23:55 ` Venki Pallipadi
2012-01-23 5:22 ` Srivatsa S. Bhat
2012-01-23 19:28 ` Venki Pallipadi
2012-01-24 2:34 ` [PATCH] Avoid mask based num_possible_cpus and num_online_cpus -v3 Venkatesh Pallipadi
2012-01-24 19:22 ` Srivatsa S. Bhat
2012-01-24 19:30 ` KOSAKI Motohiro
2012-01-24 21:01 ` Venki Pallipadi
2012-01-24 23:25 ` [PATCH] Avoid mask based num_possible_cpus and num_online_cpus -v4 Venkatesh Pallipadi
2012-01-26 17:22 ` Srivatsa S. Bhat
2012-01-26 17:27 ` Srivatsa S. Bhat
2012-01-26 21:25 ` KOSAKI Motohiro
2012-01-26 23:22 ` Andrew Morton
2012-01-27 23:58 ` Venki Pallipadi
2012-02-01 0:17 ` [PATCH] Avoid mask based num_possible_cpus and num_online_cpus -v5 Venkatesh Pallipadi
2012-02-01 22:01 ` Andrew Morton
2012-02-02 20:03 ` Rusty Russell
2012-02-02 20:19 ` Andrew Morton
2012-02-02 21:00 ` Venki Pallipadi
2012-02-13 19:54 ` Tony Luck
2012-02-13 20:04 ` Venki Pallipadi
2012-02-13 20:25 ` Srivatsa S. Bhat
2012-02-13 20:43 ` Venki Pallipadi
2012-02-13 20:55 ` Srivatsa S. Bhat
2012-02-13 20:44 ` Srivatsa S. Bhat
2012-02-13 21:57 ` Tony Luck
2012-02-14 9:25 ` Rusty Russell
2012-02-14 21:35 ` Srivatsa S. Bhat
2012-02-14 23:00 ` Tony Luck
2012-02-14 22:49 ` [PATCH 0/3] Cleanup raw handling of online/possible map Venkatesh Pallipadi
2012-02-14 22:49 ` [PATCH 1/3] hexagon: Avoid raw handling of cpu_possible_map Venkatesh Pallipadi
2012-02-14 22:49 ` [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map Venkatesh Pallipadi
2012-02-27 22:19 ` David Daney [this message]
2012-02-14 22:49 ` [PATCH 3/3] um: Avoid raw handling of cpu_online_map Venkatesh Pallipadi
2012-02-27 21:55 ` [PATCH] Avoid mask based num_possible_cpus and num_online_cpus -v5 David Daney
2012-02-27 22:07 ` Andrew Morton
2012-02-27 22:16 ` David Daney
2012-03-01 18:32 ` Venki Pallipadi
2012-02-28 5:01 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4C017E.5040200@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.gortmaker@windriver.com \
--cc=paul.mckenney@linaro.org \
--cc=ralf@linux-mips.org \
--cc=richard@nod.at \
--cc=rjw@sisk.pl \
--cc=rkuo@codeaurora.org \
--cc=rusty@rustcorp.com.au \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tony.luck@gmail.com \
--cc=travis@sgi.com \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).