From: Tilman Schmidt <tilman@imap.cc>
To: Joe Perches <joe@perches.com>
Cc: Jiri Slaby <jslaby@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
Hansjoerg Lipp <hjlipp@web.de>,
gigaset307x-common@lists.sourceforge.net,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: "whitespace coding style cleanup" broke coding style
Date: Tue, 28 Feb 2012 18:58:57 +0100 [thread overview]
Message-ID: <4F4D15E1.3090306@imap.cc> (raw)
In-Reply-To: <1330361549.9942.7.camel@joe2Laptop>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 27.02.2012 17:52, Joe Perches wrote:
> On Mon, 2012-02-27 at 09:59 +0100, Jiri Slaby wrote:
>> commit 475be4d85a274d0961593db41cf85689db1d583c
>> Author: Joe Perches <joe@perches.com>
>> Date: Sun Feb 19 19:52:38 2012 -0800
>>
>> isdn: whitespace coding style cleanup
>>
>> isdn source code uses a not-current coding style.
[...]
> It was a first pass and an overall improvement.
I'm not so sure about that, but I'm probably biased.
What grieves me more is how that patch was sneaked in without any
notification to the maintainers of the code in question. With the
customary CC, we could have caught the problems before they reached
- -next.
> I'm working on improving the logging style
> in isdn and will submit more patches soonish.
Please remember to CC the maintainers of the affected code this time.
Thanks,
Tilman
- --
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/
iEYEARECAAYFAk9NFeEACgkQQ3+did9BuFvG2ACdGL+9IMooAmMAlJwON2kHU+f8
2V4AnjjdZDNwaNGQuLVRKS100TfG6i+e
=FKIs
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-02-28 17:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 8:59 "whitespace coding style cleanup" broke coding style Jiri Slaby
2012-02-27 11:19 ` Tilman Schmidt
2012-02-27 11:34 ` Jiri Slaby
2012-02-27 16:52 ` Joe Perches
2012-02-27 17:12 ` Jiri Slaby
2012-02-27 17:27 ` Joe Perches
2012-02-27 17:39 ` [PATCH net-next] gigaset: Use semicolons to terminate statements Joe Perches
2012-02-27 19:12 ` David Miller
2012-02-27 18:58 ` "whitespace coding style cleanup" broke coding style Jiri Slaby
2012-02-28 17:58 ` Tilman Schmidt [this message]
2012-02-28 22:05 ` Joe Perches
2012-02-28 23:08 ` Tilman Schmidt
2012-02-28 23:28 ` Joe Perches
2012-02-28 23:42 ` David Miller
2012-02-29 0:41 ` Alan Cox
2012-02-29 8:27 ` Armin Schindler
2012-02-29 19:32 ` Joe Perches
2012-02-29 11:05 ` Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4D15E1.3090306@imap.cc \
--to=tilman@imap.cc \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=jirislaby@gmail.com \
--cc=joe@perches.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).