* [PATCH] get_maintainer.pl: Add support for moderated lists
@ 2012-02-29 19:49 Richard Weinberger
2012-02-29 19:58 ` Joe Perches
2012-03-02 17:13 ` Joe Perches
0 siblings, 2 replies; 10+ messages in thread
From: Richard Weinberger @ 2012-02-29 19:49 UTC (permalink / raw)
To: joe; +Cc: akpm, Ian.Campbell, florian, linux-kernel, Richard Weinberger
Currently get_maintainer.pl reports moderated lists as open,
which is just wrong.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
scripts/get_maintainer.pl | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index f32a04c..b9bcfb6 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -1027,8 +1027,13 @@ sub add_categories {
if ($email_list) {
if (!$hash_list_to{lc($list_address)}) {
$hash_list_to{lc($list_address)} = 1;
- push(@list_to, [$list_address,
- "open list${list_role}"]);
+ if ($list_additional =~ m/moderated/) {
+ push(@list_to, [$list_address,
+ "moderated list${list_role}"]);
+ } else {
+ push(@list_to, [$list_address,
+ "open list${list_role}"]);
+ }
}
}
}
--
1.7.7.3
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-02-29 19:49 [PATCH] get_maintainer.pl: Add support for moderated lists Richard Weinberger
@ 2012-02-29 19:58 ` Joe Perches
2012-02-29 20:06 ` Richard Weinberger
2012-03-02 17:13 ` Joe Perches
1 sibling, 1 reply; 10+ messages in thread
From: Joe Perches @ 2012-02-29 19:58 UTC (permalink / raw)
To: Richard Weinberger; +Cc: akpm, Ian.Campbell, florian, linux-kernel
On Wed, 2012-02-29 at 20:49 +0100, Richard Weinberger wrote:
> Currently get_maintainer.pl reports moderated lists as open,
> which is just wrong.
Hi Richard.
<shrug> From my perspective, it's correct and simple.
Moderated lists just means your email may get delayed
and you may get a "delayed due to moderation" email.
It's not a big deal to me though if Andrew wants to pick
this up. It seems that all current lists are marked
the same way. You might consider using a case insensitive
m/\(moderated/i though in case some list has moderated
in the email address itself.
cheers, Joe
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> scripts/get_maintainer.pl | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index f32a04c..b9bcfb6 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1027,8 +1027,13 @@ sub add_categories {
> if ($email_list) {
> if (!$hash_list_to{lc($list_address)}) {
> $hash_list_to{lc($list_address)} = 1;
> - push(@list_to, [$list_address,
> - "open list${list_role}"]);
> + if ($list_additional =~ m/moderated/) {
> + push(@list_to, [$list_address,
> + "moderated list${list_role}"]);
> + } else {
> + push(@list_to, [$list_address,
> + "open list${list_role}"]);
> + }
> }
> }
> }
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-02-29 19:58 ` Joe Perches
@ 2012-02-29 20:06 ` Richard Weinberger
2012-02-29 20:16 ` Joe Perches
2012-03-01 0:02 ` Andrew Morton
0 siblings, 2 replies; 10+ messages in thread
From: Richard Weinberger @ 2012-02-29 20:06 UTC (permalink / raw)
To: Joe Perches; +Cc: akpm, Ian.Campbell, florian, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
Joe,
Am 29.02.2012 20:58, schrieb Joe Perches:
> <shrug> From my perspective, it's correct and simple.
>
> Moderated lists just means your email may get delayed
> and you may get a "delayed due to moderation" email.
Most moderated lists are "moderated" by nobody and the patch
goes to /dev/null.
> It's not a big deal to me though if Andrew wants to pick
> this up. It seems that all current lists are marked
> the same way. You might consider using a case insensitive
> m/\(moderated/i though in case some list has moderated
> in the email address itself.
Let's keep the regular expressions as simple as possible.
get_maintainer.pl is already damn slow enough.
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-02-29 20:06 ` Richard Weinberger
@ 2012-02-29 20:16 ` Joe Perches
2012-03-01 0:02 ` Andrew Morton
1 sibling, 0 replies; 10+ messages in thread
From: Joe Perches @ 2012-02-29 20:16 UTC (permalink / raw)
To: Richard Weinberger; +Cc: akpm, Ian.Campbell, florian, linux-kernel
On Wed, 2012-02-29 at 21:06 +0100, Richard Weinberger wrote:
> Joe,
>
> Am 29.02.2012 20:58, schrieb Joe Perches:
> > <shrug> From my perspective, it's correct and simple.
> >
> > Moderated lists just means your email may get delayed
> > and you may get a "delayed due to moderation" email.
>
> Most moderated lists are "moderated" by nobody and the patch
> goes to /dev/null.
>
> > It's not a big deal to me though if Andrew wants to pick
> > this up. It seems that all current lists are marked
> > the same way. You might consider using a case insensitive
> > m/\(moderated/i though in case some list has moderated
> > in the email address itself.
>
> Let's keep the regular expressions as simple as possible.
No, let's make the expressions as specific as possible.
The expression change is trivial and wouldn't have much
effect on a 25Mhz 386.
> get_maintainer.pl is already damn slow enough.
It's pretty darn fast if you don't use --git
or --git-fallback. --git is the thing that's slow.
On my slow netbook:
$ time ./scripts/get_maintainer.pl --nogit --nogit-fallback -f drivers/net/ethernet/intel/e1000e/mac.c
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (supporter:INTEL ETHERNET DR...)
Jesse Brandeburg <jesse.brandeburg@intel.com> (supporter:INTEL ETHERNET DR...)
Bruce Allan <bruce.w.allan@intel.com> (supporter:INTEL ETHERNET DR...)
Carolyn Wyborny <carolyn.wyborny@intel.com> (supporter:INTEL ETHERNET DR...)
Don Skidmore <donald.c.skidmore@intel.com> (supporter:INTEL ETHERNET DR...)
Greg Rose <gregory.v.rose@intel.com> (supporter:INTEL ETHERNET DR...)
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> (supporter:INTEL ETHERNET DR...)
Alex Duyck <alexander.h.duyck@intel.com> (supporter:INTEL ETHERNET DR...)
John Ronciak <john.ronciak@intel.com> (supporter:INTEL ETHERNET DR...)
e1000-devel@lists.sourceforge.net (open list:INTEL ETHERNET DR...)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
real 0m0.716s
user 0m0.512s
sys 0m0.016s
An old desktop:
$ time ./scripts/get_maintainer.pl --nogit --nogit-fallback -f drivers/net/ethernet/intel/e1000e/mac.c
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (supporter:INTEL ETHERNET DR...)
Jesse Brandeburg <jesse.brandeburg@intel.com> (supporter:INTEL ETHERNET DR...)
Bruce Allan <bruce.w.allan@intel.com> (supporter:INTEL ETHERNET DR...)
Carolyn Wyborny <carolyn.wyborny@intel.com> (supporter:INTEL ETHERNET DR...)
Don Skidmore <donald.c.skidmore@intel.com> (supporter:INTEL ETHERNET DR...)
Greg Rose <gregory.v.rose@intel.com> (supporter:INTEL ETHERNET DR...)
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> (supporter:INTEL ETHERNET DR...)
Alex Duyck <alexander.h.duyck@intel.com> (supporter:INTEL ETHERNET DR...)
John Ronciak <john.ronciak@intel.com> (supporter:INTEL ETHERNET DR...)
e1000-devel@lists.sourceforge.net (open list:INTEL ETHERNET DR...)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
real 0m0.250s
user 0m0.128s
sys 0m0.024s
Using git on the desktop (linux-next)
$ time ./scripts/get_maintainer.pl -f drivers/net/ethernet/intel/e1000e/mac.c
Jeff Kirsher <jeffrey.t.kirsher@intel.com> (supporter:INTEL ETHERNET DR...,commit_signer:17/19=89%)
Jesse Brandeburg <jesse.brandeburg@intel.com> (supporter:INTEL ETHERNET DR...)
Bruce Allan <bruce.w.allan@intel.com> (supporter:INTEL ETHERNET DR...,commit_signer:15/19=79%)
Carolyn Wyborny <carolyn.wyborny@intel.com> (supporter:INTEL ETHERNET DR...)
Don Skidmore <donald.c.skidmore@intel.com> (supporter:INTEL ETHERNET DR...)
Greg Rose <gregory.v.rose@intel.com> (supporter:INTEL ETHERNET DR...)
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> (supporter:INTEL ETHERNET DR...)
Alex Duyck <alexander.h.duyck@intel.com> (supporter:INTEL ETHERNET DR...)
John Ronciak <john.ronciak@intel.com> (supporter:INTEL ETHERNET DR...)
"David S. Miller" <davem@davemloft.net> (commit_signer:2/19=11%)
Tobias Klauser <tklauser@distanz.ch> (commit_signer:1/19=5%)
Jon Mason <jdmason@kudzu.us> (commit_signer:1/19=5%)
e1000-devel@lists.sourceforge.net (open list:INTEL ETHERNET DR...)
netdev@vger.kernel.org (open list:NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
real 0m13.357s
user 0m9.649s
sys 0m0.388s
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-02-29 20:06 ` Richard Weinberger
2012-02-29 20:16 ` Joe Perches
@ 2012-03-01 0:02 ` Andrew Morton
2012-03-01 0:27 ` Richard Weinberger
2012-03-01 1:17 ` Joe Perches
1 sibling, 2 replies; 10+ messages in thread
From: Andrew Morton @ 2012-03-01 0:02 UTC (permalink / raw)
To: Richard Weinberger; +Cc: Joe Perches, Ian.Campbell, florian, linux-kernel
On Wed, 29 Feb 2012 21:06:45 +0100
Richard Weinberger <richard@nod.at> wrote:
> Am 29.02.2012 20:58, schrieb Joe Perches:
> > <shrug> From my perspective, it's correct and simple.
> >
> > Moderated lists just means your email may get delayed
> > and you may get a "delayed due to moderation" email.
>
> Most moderated lists are "moderated" by nobody and the patch
> goes to /dev/null.
That's a big problem - we don't want people to send their fixes and bug
reports into black holes.
So yes, I think that teaching get_maintainer to emit black hole
warnings is a good idea.
Problem is, I don't think the string "moderated" explains the situation
very well for the uninitiated :(
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-03-01 0:02 ` Andrew Morton
@ 2012-03-01 0:27 ` Richard Weinberger
2012-03-01 1:17 ` Joe Perches
1 sibling, 0 replies; 10+ messages in thread
From: Richard Weinberger @ 2012-03-01 0:27 UTC (permalink / raw)
To: Andrew Morton; +Cc: Joe Perches, Ian.Campbell, florian, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
Am 01.03.2012 01:02, schrieb Andrew Morton:
> Problem is, I don't think the string "moderated" explains the situation
> very well for the uninitiated :(
At least it does not lie by claiming it's open. ;-)
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-03-01 0:02 ` Andrew Morton
2012-03-01 0:27 ` Richard Weinberger
@ 2012-03-01 1:17 ` Joe Perches
2012-03-02 15:02 ` Richard Weinberger
1 sibling, 1 reply; 10+ messages in thread
From: Joe Perches @ 2012-03-01 1:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: Richard Weinberger, Ian.Campbell, florian, linux-kernel
On Wed, 2012-02-29 at 16:02 -0800, Andrew Morton wrote:
> On Wed, 29 Feb 2012 21:06:45 +0100
> Richard Weinberger <richard@nod.at> wrote:
>
> > Am 29.02.2012 20:58, schrieb Joe Perches:
> > > <shrug> From my perspective, it's correct and simple.
> > >
> > > Moderated lists just means your email may get delayed
> > > and you may get a "delayed due to moderation" email.
> >
> > Most moderated lists are "moderated" by nobody and the patch
> > goes to /dev/null.
>
> That's a big problem - we don't want people to send their fixes and bug
> reports into black holes.
>
> So yes, I think that teaching get_maintainer to emit black hole
> warnings is a good idea.
>
> Problem is, I don't think the string "moderated" explains the situation
> very well for the uninitiated :(
It's also false. Most moderated lists in MAINTAINERS
(and I've probably send patches to most of them) are
in fact moderated.
My patches generally show up in their list archives.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-03-01 1:17 ` Joe Perches
@ 2012-03-02 15:02 ` Richard Weinberger
2012-03-02 21:18 ` Jonas Bonn
0 siblings, 1 reply; 10+ messages in thread
From: Richard Weinberger @ 2012-03-02 15:02 UTC (permalink / raw)
To: Joe Perches; +Cc: Andrew Morton, Ian.Campbell, florian, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
Am 01.03.2012 02:17, schrieb Joe Perches:
> On Wed, 2012-02-29 at 16:02 -0800, Andrew Morton wrote:
>> On Wed, 29 Feb 2012 21:06:45 +0100
>> Richard Weinberger <richard@nod.at> wrote:
>>
>>> Am 29.02.2012 20:58, schrieb Joe Perches:
>>>> <shrug> From my perspective, it's correct and simple.
>>>>
>>>> Moderated lists just means your email may get delayed
>>>> and you may get a "delayed due to moderation" email.
>>>
>>> Most moderated lists are "moderated" by nobody and the patch
>>> goes to /dev/null.
>>
>> That's a big problem - we don't want people to send their fixes and bug
>> reports into black holes.
>>
>> So yes, I think that teaching get_maintainer to emit black hole
>> warnings is a good idea.
>>
>> Problem is, I don't think the string "moderated" explains the situation
>> very well for the uninitiated :(
>
> It's also false. Most moderated lists in MAINTAINERS
> (and I've probably send patches to most of them) are
> in fact moderated.
What about linux@lists.openrisc.net?
None of my patches shows up there:
http://lists.openrisc.net/pipermail/openrisc/
> My patches generally show up in their list archives.
>
You must be a lucky guy. ;-)
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-03-02 15:02 ` Richard Weinberger
@ 2012-03-02 21:18 ` Jonas Bonn
0 siblings, 0 replies; 10+ messages in thread
From: Jonas Bonn @ 2012-03-02 21:18 UTC (permalink / raw)
To: Richard Weinberger
Cc: Joe Perches, Andrew Morton, Ian.Campbell, florian, linux-kernel
On 2 March 2012 16:02, Richard Weinberger <richard@nod.at> wrote:
>
> What about linux@lists.openrisc.net?
> None of my patches shows up there:
> http://lists.openrisc.net/pipermail/openrisc/
>
Just for the record, that's the wrong URL and, consequently, wrong
mailing list... it should be:
http://lists.openrisc.net/pipermail/linux/
I don't want to be accused of maintaining a black hole... ;)
The list is moderated, but only to keep unserious posts to a minimum
(i.e. spam).
/Jonas
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] get_maintainer.pl: Add support for moderated lists
2012-02-29 19:49 [PATCH] get_maintainer.pl: Add support for moderated lists Richard Weinberger
2012-02-29 19:58 ` Joe Perches
@ 2012-03-02 17:13 ` Joe Perches
1 sibling, 0 replies; 10+ messages in thread
From: Joe Perches @ 2012-03-02 17:13 UTC (permalink / raw)
To: Richard Weinberger; +Cc: akpm, Ian.Campbell, florian, linux-kernel
On Wed, 2012-02-29 at 20:49 +0100, Richard Weinberger wrote:
> Currently get_maintainer.pl reports moderated lists as open,
> which is just wrong.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Joe Perches <joe@perches.com>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -1027,8 +1027,13 @@ sub add_categories {
> if ($email_list) {
> if (!$hash_list_to{lc($list_address)}) {
> $hash_list_to{lc($list_address)} = 1;
> - push(@list_to, [$list_address,
> - "open list${list_role}"]);
> + if ($list_additional =~ m/moderated/) {
> + push(@list_to, [$list_address,
> + "moderated list${list_role}"]);
> + } else {
> + push(@list_to, [$list_address,
> + "open list${list_role}"]);
> + }
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-03-02 21:18 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29 19:49 [PATCH] get_maintainer.pl: Add support for moderated lists Richard Weinberger
2012-02-29 19:58 ` Joe Perches
2012-02-29 20:06 ` Richard Weinberger
2012-02-29 20:16 ` Joe Perches
2012-03-01 0:02 ` Andrew Morton
2012-03-01 0:27 ` Richard Weinberger
2012-03-01 1:17 ` Joe Perches
2012-03-02 15:02 ` Richard Weinberger
2012-03-02 21:18 ` Jonas Bonn
2012-03-02 17:13 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox