From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756036Ab2CATbS (ORCPT ); Thu, 1 Mar 2012 14:31:18 -0500 Received: from mga09.intel.com ([134.134.136.24]:42534 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141Ab2CATbO (ORCPT ); Thu, 1 Mar 2012 14:31:14 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="116652969" Message-ID: <4F4FCE18.4050400@linux.intel.com> Date: Thu, 01 Mar 2012 11:29:28 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Feng Tang CC: Tomoya MORINAGA , Alan Cox , Linux Kernel Mailing List , Greg Kroah-Hartman , linux-serial@vger.kernel.org Subject: Re: [PATCH 0/4 V2] pch_uart: Cleanups, board quirks, and user uartclk parameter References: <4F4EC73E.40209@linux.intel.com> <4F4ECCE8.90207@linux.intel.com> <20120301024028.GA6612@feng-i7> In-Reply-To: <20120301024028.GA6612@feng-i7> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/29/2012 06:40 PM, Feng Tang wrote: > On Wed, Feb 29, 2012 at 05:12:08PM -0800, Darren Hart wrote: >> >> >> On 02/29/2012 05:06 PM, Tomoya MORINAGA wrote: >>> 2012年3月1日9:47 Darren Hart : >>>> how do we force the >>>> 192MHz clock setting BEFORE the pch_phub code runs? >>> >>> To realize your requirement, >>> I think that set by BIOS is only way. >> >> Perhaps a pch_phub.bios_uartclk parameter could be used for setting up >> the initial console and once the phub driver is loaded, it can make the >> necessary changes and fix things up in the uart port? This would add a >> binding between the pch_uart and pch_phub code. >> >> Thoughts? > > To satisfy the early console, one way may be add a x86_init_ops for all > Tunnel Creek compatible platform like what Moorestown/Medfield have done, > and insert the uart clk setting work into one of the early init function. > I believe this is inline with what Alan was recommending in his response to the V1 patch series, and it sounds like a reasonable next step. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel