From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755563Ab2CBVdA (ORCPT ); Fri, 2 Mar 2012 16:33:00 -0500 Received: from terminus.zytor.com ([198.137.202.10]:47510 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577Ab2CBVc7 (ORCPT ); Fri, 2 Mar 2012 16:32:59 -0500 Message-ID: <4F513C80.2090709@zytor.com> Date: Fri, 02 Mar 2012 13:32:48 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 MIME-Version: 1.0 To: "Joshua C." CC: Bodo Eggert <7eggert@gmx.de>, linux-kernel@vger.kernel.org, Alan Cox Subject: Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock References: <4F4C1F76.70403@zytor.com> <4F4D1E6A.5000200@zytor.com> <4F4E6B98.2090306@zytor.com> <4F4EB0B9.2080906@zytor.com> <4F4EBF44.60208@zytor.com> <4F4EC19F.4050002@zytor.com> <4F4FE1FA.1040008@zytor.com> <4F51114D.80704@zytor.com> In-Reply-To: X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/02/2012 01:21 PM, Joshua C. wrote: > 2012/3/2 H. Peter Anvin : >> >> Yeah, it seems a bit excessive in this case. >> >> -hpa >> >> -- >> H. Peter Anvin, Intel Open Source Technology Center >> I work for Intel. I don't speak on their behalf. >> > > This is the final version. It works fine here on one laptop and a desktop. > > @Alan > Can you, please, queue this for the mainline and also push it to > stable? The patch is straight forward and set the NumLock on a > keyboard according to the data in the BIOS. > I still prefer the inline function instead of a macro for KBD_DEFLEDS, but this is in deep nitpick territory at this point, and the macro is already there. Reviewed-by: H. Peter Anvin -hpa