From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762Ab2CCHAf (ORCPT ); Sat, 3 Mar 2012 02:00:35 -0500 Received: from merlin.infradead.org ([205.233.59.134]:46521 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203Ab2CCHAe (ORCPT ); Sat, 3 Mar 2012 02:00:34 -0500 Message-ID: <4F51C18C.5080903@kernel.dk> Date: Sat, 03 Mar 2012 08:00:28 +0100 From: Jens Axboe MIME-Version: 1.0 To: Dan Carpenter CC: Jeff Garzik , Tejun Heo , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] block, sx8: fix pointer math issue getting fw version References: <20120302190042.GB3951@elgon.mountain> <4F51C103.507@kernel.dk> In-Reply-To: <4F51C103.507@kernel.dk> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2012-03-03 07:58, Jens Axboe wrote: > On 2012-03-02 20:00, Dan Carpenter wrote: >> "mem" is type u8. We need parenthesis here or it screws up the pointer >> math probably leading to an oops. > > Applied, thanks Dan. I have marked it stable, too. Hmm wait Dan, seems to me that u8 pointer math should be equiv to char * pointer math and hence it'd work just fine. Are you sure this is a bug? -- Jens Axboe