* [PATCH 1/1] samsung-laptop: add N230 to supported models
@ 2012-03-02 18:55 Jiri Slaby
2012-03-02 19:06 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Slaby @ 2012-03-02 18:55 UTC (permalink / raw)
To: mjg; +Cc: platform-driver-x86, linux-kernel
There is a version of N230 which has only this in product and board
names. See dmidecode in the bugzilla entry.
Without this patch, one has to pass the force module parameter to have
rfkill working.
References: https://bugzilla.novell.com/show_bug.cgi?id=746695
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/platform/x86/samsung-laptop.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
index fd73ea8..7765929 100644
--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -679,6 +679,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
.callback = dmi_check_cb,
},
{
+ .ident = "N230",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR,
+ "SAMSUNG ELECTRONICS CO., LTD."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "N230"),
+ DMI_MATCH(DMI_BOARD_NAME, "N230"),
+ },
+ .callback = dmi_check_cb,
+ },
+ {
.ident = "N150/N210/N220/N230",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR,
--
1.7.9.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] samsung-laptop: add N230 to supported models
2012-03-02 18:55 [PATCH 1/1] samsung-laptop: add N230 to supported models Jiri Slaby
@ 2012-03-02 19:06 ` Josh Boyer
2012-03-04 10:52 ` Corentin Chary
0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2012-03-02 19:06 UTC (permalink / raw)
To: Jiri Slaby; +Cc: mjg, platform-driver-x86, linux-kernel
On Fri, Mar 2, 2012 at 1:55 PM, Jiri Slaby <jslaby@suse.cz> wrote:
> There is a version of N230 which has only this in product and board
> names. See dmidecode in the bugzilla entry.
>
> Without this patch, one has to pass the force module parameter to have
> rfkill working.
>
> References: https://bugzilla.novell.com/show_bug.cgi?id=746695
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
I think Corey has patches queued up in Matthew's git tree that drop the DMI
checks in this driver entirely. If so, this probably isn't needed.
josh
> ---
> drivers/platform/x86/samsung-laptop.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c
> index fd73ea8..7765929 100644
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -679,6 +679,16 @@ static struct dmi_system_id __initdata samsung_dmi_table[] = {
> .callback = dmi_check_cb,
> },
> {
> + .ident = "N230",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR,
> + "SAMSUNG ELECTRONICS CO., LTD."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "N230"),
> + DMI_MATCH(DMI_BOARD_NAME, "N230"),
> + },
> + .callback = dmi_check_cb,
> + },
> + {
> .ident = "N150/N210/N220/N230",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR,
> --
> 1.7.9.2
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] samsung-laptop: add N230 to supported models
2012-03-02 19:06 ` Josh Boyer
@ 2012-03-04 10:52 ` Corentin Chary
2012-03-04 13:40 ` Jiri Slaby
0 siblings, 1 reply; 5+ messages in thread
From: Corentin Chary @ 2012-03-04 10:52 UTC (permalink / raw)
To: Josh Boyer; +Cc: Jiri Slaby, mjg, platform-driver-x86, linux-kernel
On Fri, Mar 2, 2012 at 8:06 PM, Josh Boyer <jwboyer@gmail.com> wrote:
> On Fri, Mar 2, 2012 at 1:55 PM, Jiri Slaby <jslaby@suse.cz> wrote:
>> There is a version of N230 which has only this in product and board
>> names. See dmidecode in the bugzilla entry.
>>
>> Without this patch, one has to pass the force module parameter to have
>> rfkill working.
>>
>> References: https://bugzilla.novell.com/show_bug.cgi?id=746695
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>
> I think Corey has patches queued up in Matthew's git tree that drop the DMI
> checks in this driver entirely. If so, this probably isn't needed.
Right. You can try the out-of-tree module using this repository
https://github.com/iksaif/samsung-laptop-dkms . The patchs are in
Matthew queue and they should be merged in 3.4.
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] samsung-laptop: add N230 to supported models
2012-03-04 10:52 ` Corentin Chary
@ 2012-03-04 13:40 ` Jiri Slaby
2012-03-05 6:35 ` Corentin Chary
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Slaby @ 2012-03-04 13:40 UTC (permalink / raw)
To: Corentin Chary
Cc: Josh Boyer, Jiri Slaby, mjg, platform-driver-x86, linux-kernel
On 03/04/2012 11:52 AM, Corentin Chary wrote:
> On Fri, Mar 2, 2012 at 8:06 PM, Josh Boyer <jwboyer@gmail.com> wrote:
>> On Fri, Mar 2, 2012 at 1:55 PM, Jiri Slaby <jslaby@suse.cz> wrote:
>>> There is a version of N230 which has only this in product and board
>>> names. See dmidecode in the bugzilla entry.
>>>
>>> Without this patch, one has to pass the force module parameter to have
>>> rfkill working.
>>>
>>> References: https://bugzilla.novell.com/show_bug.cgi?id=746695
>>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>>
>> I think Corey has patches queued up in Matthew's git tree that drop the DMI
>> checks in this driver entirely. If so, this probably isn't needed.
>
> Right. You can try the out-of-tree module using this repository
> https://github.com/iksaif/samsung-laptop-dkms . The patchs are in
> Matthew queue and they should be merged in 3.4.
Ok, thanks. Then please merge with -next ASAP.
--
js
suse labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] samsung-laptop: add N230 to supported models
2012-03-04 13:40 ` Jiri Slaby
@ 2012-03-05 6:35 ` Corentin Chary
0 siblings, 0 replies; 5+ messages in thread
From: Corentin Chary @ 2012-03-05 6:35 UTC (permalink / raw)
To: platform-driver-x86, mjg; +Cc: Josh Boyer, Jiri Slaby, linux-kernel
On Sun, Mar 4, 2012 at 2:40 PM, Jiri Slaby <jslaby@suse.cz> wrote:
> On 03/04/2012 11:52 AM, Corentin Chary wrote:
>> On Fri, Mar 2, 2012 at 8:06 PM, Josh Boyer <jwboyer@gmail.com> wrote:
>>> On Fri, Mar 2, 2012 at 1:55 PM, Jiri Slaby <jslaby@suse.cz> wrote:
>>>> There is a version of N230 which has only this in product and board
>>>> names. See dmidecode in the bugzilla entry.
>>>>
>>>> Without this patch, one has to pass the force module parameter to have
>>>> rfkill working.
>>>>
>>>> References: https://bugzilla.novell.com/show_bug.cgi?id=746695
>>>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>>>
>>> I think Corey has patches queued up in Matthew's git tree that drop the DMI
>>> checks in this driver entirely. If so, this probably isn't needed.
>>
>> Right. You can try the out-of-tree module using this repository
>> https://github.com/iksaif/samsung-laptop-dkms . The patchs are in
>> Matthew queue and they should be merged in 3.4.
>
> Ok, thanks. Then please merge with -next ASAP.
Matthew, is your new tree
(git://cavan.codon.org.uk/platform-drivers-x86.git) merged in -next ?
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-03-05 6:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 18:55 [PATCH 1/1] samsung-laptop: add N230 to supported models Jiri Slaby
2012-03-02 19:06 ` Josh Boyer
2012-03-04 10:52 ` Corentin Chary
2012-03-04 13:40 ` Jiri Slaby
2012-03-05 6:35 ` Corentin Chary
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox