From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932458Ab2CEODs (ORCPT ); Mon, 5 Mar 2012 09:03:48 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:42119 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932286Ab2CEODp (ORCPT ); Mon, 5 Mar 2012 09:03:45 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of jirislaby@gmail.com designates 10.213.2.68 as permitted sender) smtp.mail=jirislaby@gmail.com; dkim=pass header.i=jirislaby@gmail.com Message-ID: <4F54C7BD.1020105@suse.cz> Date: Mon, 05 Mar 2012 15:03:41 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120222 Thunderbird/11.0 MIME-Version: 1.0 To: Jiri Slaby CC: gregkh@linuxfoundation.org, alan@linux.intel.com, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Neukum , USB list Subject: Re: [PATCH 01/68] USB: cdc-acm, use tty_standard_install References: <1330955575-26641-1-git-send-email-jslaby@suse.cz> <1330955575-26641-2-git-send-email-jslaby@suse.cz> In-Reply-To: <1330955575-26641-2-git-send-email-jslaby@suse.cz> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Forgot to CC maintainers. Done now. On 03/05/2012 02:51 PM, Jiri Slaby wrote: > This is a piece I missed the last time. > > Do not copy the functionality all over the tree. Instead, use the > helper the tty layer provides us with. > > Signed-off-by: Jiri Slaby > --- > drivers/usb/class/cdc-acm.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index 6dcc3a3..b3fd449 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -509,17 +509,12 @@ static int acm_tty_install(struct tty_driver *driver, struct tty_struct *tty) > if (!acm) > return -ENODEV; > > - retval = tty_init_termios(tty); > + retval = tty_standard_install(driver, tty); > if (retval) > goto error_init_termios; > > tty->driver_data = acm; > > - /* Final install (we use the default method) */ > - tty_driver_kref_get(driver); > - tty->count++; > - driver->ttys[tty->index] = tty; > - > return 0; > > error_init_termios: -- js suse labs