From: Alexander Graf <agraf@suse.de>
To: Ben Collins <bcollins@ubuntu.com>
Cc: kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: PPC: check error return of kvmppc_core_vcpu_create first
Date: Mon, 05 Mar 2012 19:10:59 +0100 [thread overview]
Message-ID: <4F5501B3.6050601@suse.de> (raw)
In-Reply-To: <50A8F108-8055-4115-B4EB-706D97736E65@ubuntu.com>
On 02/21/2012 05:30 AM, Ben Collins wrote:
> The result of kvmppc_core_vcpu_create() was being manipulated before it was checked for IS_ERR(). Did not see the bug occur, but caught it when looking through the code.
Nice catch, but this has already been fixed by Matt:
commit c6f3830e7313eea47b526b597aadc5b18c69ad55
Author: Matt Evans <matt@ozlabs.org>
Date: Tue Dec 6 21:19:42 2011 +0000
KVM: PPC: Fix vcpu_create dereference before validity check.
Fix usage of vcpu struct before check that it's actually valid.
Signed-off-by: Matt Evans <matt@ozlabs.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
Thanks a lot for sending the patch nevertheless!
Alex
prev parent reply other threads:[~2012-03-05 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 4:30 [PATCH] KVM: PPC: check error return of kvmppc_core_vcpu_create first Ben Collins
2012-03-05 18:10 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5501B3.6050601@suse.de \
--to=agraf@suse.de \
--cc=bcollins@ubuntu.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox