linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arun Sharma <asharma@fb.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>,
	Stephane Eranian <eranian@google.com>,
	<linux-kernel@vger.kernel.org>, <dsahern@gmail.com>,
	<ravitillo@lbl.gov>, <khandual@linux.vnet.ibm.com>,
	<robert.richter@amd.com>, <ming.m.lin@intel.com>,
	<vweaver1@eecs.utk.edu>, <andi@firstfloor.org>
Subject: Re: [PATCH] perf report: auto-detect branch stack sampling mode
Date: Mon, 5 Mar 2012 15:35:35 -0800	[thread overview]
Message-ID: <4F554DC7.8010504@fb.com> (raw)
In-Reply-To: <20120305222614.GB5656@infradead.org>


Like you probably figured from my other mail, we deal with deeply nested 
callchains with unwieldy function names a lot -- thanks to C++ and 
template programming. --tui's collapsing/expanding functionality is 
quite useful to navigate that mess. I'm just taking this opportunity to 
get some attention focused on improving it :)

On 3/5/12 2:26 PM, Arnaldo Carvalho de Melo wrote:

>> Here's an example:
>>
>> # perf record -ag -- sleep 3
>> # perf report -G -s pid --tui # SIGSEGV
>
> Ok, now this is a good report, I managed to reproduce and will work on a
> fix, thanks,

Something like this seems to do it for me.

         offset = addr - sym->start;
+       len = sym->end - sym->start;
+       if (offset >= len)
+               return 0;
+

The other problem area seems to be callchains when using -p regexp -x 
options. I'll try to summarize problems there in a separate thread.

  -Arun

  reply	other threads:[~2012-03-05 23:36 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24  9:40 [PATCH] perf report: auto-detect branch stack sampling mode Stephane Eranian
2012-02-24 15:24 ` David Ahern
2012-02-24 15:28   ` Stephane Eranian
2012-02-24 15:31     ` David Ahern
2012-02-24 15:40       ` Stephane Eranian
2012-02-24 15:49         ` David Ahern
2012-02-24 15:51           ` Stephane Eranian
2012-03-02 17:47             ` Stephane Eranian
2012-03-02 19:08               ` Arnaldo Carvalho de Melo
2012-03-03 19:43                 ` Arnaldo Carvalho de Melo
2012-03-05 10:49                   ` Ingo Molnar
2012-03-05 11:11                     ` Peter Zijlstra
2012-03-05 15:47 ` Ingo Molnar
2012-03-05 15:50   ` Ingo Molnar
2012-03-05 15:56     ` Ingo Molnar
2012-03-05 16:30       ` Peter Zijlstra
2012-03-05 16:32         ` Stephane Eranian
2012-03-05 17:20           ` Ingo Molnar
2012-03-05 20:35         ` Arnaldo Carvalho de Melo
2012-03-05 21:43           ` Arun Sharma
2012-03-05 22:26             ` Arnaldo Carvalho de Melo
2012-03-05 23:35               ` Arun Sharma [this message]
2012-03-06  3:06                 ` Arnaldo Carvalho de Melo
2012-03-06  6:27                   ` Ingo Molnar
2012-03-06  6:25                 ` Ingo Molnar
2012-03-07  1:57                   ` [RFC] perf report: Implement symbol filtering on TUI Namhyung Kim
2012-03-07  6:07                     ` Ingo Molnar
2012-03-07  8:04                       ` Namhyung Kim
2012-03-08 10:44                         ` Ingo Molnar
2012-03-09  1:53                           ` Namhyung Kim
2012-03-09  7:36                             ` Ingo Molnar
2012-03-09  8:03                               ` Namhyung Kim
2012-03-14 23:11                     ` Arun Sharma
2012-03-15  0:44                       ` Namhyung Kim
2012-03-15 21:46                         ` Arun Sharma
2012-03-05 15:52   ` [PATCH] perf report: auto-detect branch stack sampling mode Stephane Eranian
2012-03-07 12:49   ` Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F554DC7.8010504@fb.com \
    --to=asharma@fb.com \
    --cc=acme@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=ravitillo@lbl.gov \
    --cc=robert.richter@amd.com \
    --cc=vweaver1@eecs.utk.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).