From: Shubhrajyoti <shubhrajyoti@ti.com>
To: "Cousson, Benoit" <b-cousson@ti.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] spi/omap: Trivial cleanup
Date: Tue, 06 Mar 2012 18:45:13 +0530 [thread overview]
Message-ID: <4F560DE1.3090809@ti.com> (raw)
In-Reply-To: <4F55E412.5050409@ti.com>
On Tuesday 06 March 2012 03:46 PM, Cousson, Benoit wrote:
> Hi Shubhro,
>
> On 2/29/2012 3:04 PM, Shubhrajyoti D wrote:
>> The context is stored directly inside drvdata structure post
>> [f887876 spi/omap: Remove bus_num usage for instance index].
>> Remove the OMAP2_MCSPI_MAX_CTRL macro as it is not needed anymore.
>>
>> Cc: Benoit Cousson<b-cousson@ti.com>
>> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
>
> Thanks for that extra cleanup, I missed it.
>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
>
>> ---
>> Applies on Benoit's for_3.4/dt_spi_eth
>>
>> drivers/spi/spi-omap2-mcspi.c | 3 ---
>> 1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/spi/spi-omap2-mcspi.c
>> b/drivers/spi/spi-omap2-mcspi.c
>> index d1eb26c..3526281 100644
>> --- a/drivers/spi/spi-omap2-mcspi.c
>> +++ b/drivers/spi/spi-omap2-mcspi.c
>> @@ -45,9 +45,6 @@
>>
>> #define OMAP2_MCSPI_MAX_FREQ 48000000
>>
>> -/* OMAP2 has 3 SPI controllers, while OMAP3 has 4 */
>> -#define OMAP2_MCSPI_MAX_CTRL 4
>> -
>
> I guess it can be included in the "spi/omap: Remove bus_num usage for
> instance index"?
> Is that OK for you?
Yes, sure.
>
>
> Thanks,
> Benoit
>
prev parent reply other threads:[~2012-03-06 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 14:04 [PATCH RFC] spi/omap: Trivial cleanup Shubhrajyoti D
2012-03-06 10:16 ` Cousson, Benoit
2012-03-06 13:15 ` Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F560DE1.3090809@ti.com \
--to=shubhrajyoti@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).