From: Stephen Warren <swarren@wwwdotorg.org>
To: Dmitry Artamonow <mad_soft@inbox.ru>
Cc: linux-tegra@vger.kernel.org, Colin Cross <ccross@android.com>,
Olof Johansson <olof@lixom.net>,
Stephen Warren <swarren@nvidia.com>,
Mike Rapoport <mike@compulab.co.il>,
Thierry Reding <thierry.reding@avionic-design.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop
Date: Tue, 06 Mar 2012 09:58:50 -0700 [thread overview]
Message-ID: <4F56424A.3020305@wwwdotorg.org> (raw)
In-Reply-To: <1331023544-6439-3-git-send-email-mad_soft@inbox.ru>
On 03/06/2012 01:45 AM, Dmitry Artamonow wrote:
> Tegra PCIe driver waits for PLL to lock using busy loop.
> If PLL fails to lock for some reason, this leads to silent lockup
> while booting (as PCIe code is not modular).
>
> Fix by adding timeout, so if PLL doesn't lock in a couple
> of seconds, just PCIe driver fails and machine continues to boot.
>
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
That seems reasonable. So once the mdelay discussion is resolved,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Any idea why the PLL doesn't lock sometimes?
next prev parent reply other threads:[~2012-03-06 17:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 8:45 [PATCH/RFC 0/2] Couple of Tegra2 PCIe fixes(?) Dmitry Artamonow
2012-03-06 8:45 ` [PATCH/RFC 1/2] arm/tegra: fix harmony pinmux for PCIe Dmitry Artamonow
2012-03-06 16:55 ` Stephen Warren
2012-03-06 8:45 ` [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop Dmitry Artamonow
2012-03-06 9:38 ` Andi
2012-03-06 11:19 ` Dmitry Artamonow
2012-03-06 16:58 ` Stephen Warren [this message]
2012-03-06 19:09 ` Thierry Reding
2012-03-06 20:15 ` Dmitry Artamonow
2012-03-09 10:09 ` [PATCH v2 " Dmitry Artamonow
2012-03-12 18:09 ` Stephen Warren
2012-03-12 19:30 ` Dmitry Artamonow
2012-03-12 19:56 ` Olof Johansson
2012-03-13 5:46 ` [PATCH] arm/tegra: pcie: fix return value of function Dmitry Artamonow
2012-03-13 19:36 ` Stephen Warren
2012-03-18 17:27 ` Olof Johansson
2012-03-07 6:38 ` [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F56424A.3020305@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ccross@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=mike@compulab.co.il \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox