Re: [PATCH v2] deal with guest paniced event

Jan Kiszka
2012-03-07T09:54:12Z

On 2012-03-07 02:58, Wen Congyang wrote:
> When the host knows the guest is paniced, it will set
> exit_reason to KVM_EXIT_GUEST_PANICED. So if qemu receive
> this exit_reason, we can send a event to tell management
> application that the guest is paniced and set the guest
> status to RUN_STATE_PANICED.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> ---
> kvm-all.c | 4 ++++
> linux-headers/linux/kvm.h | 1 +
> monitor.c | 3 +++
> monitor.h | 1 +
> qapi-schema.json | 2 +-
> qmp.c | 3 ++-
> vl.c | 1 +
> 7 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index c4babda..d356948 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1190,6 +1190,10 @@ int kvm_cpu_exec(CPUState *env)
> (uint64_t)run->hw.hardware_exit_reason);
> ret = -1;
> break;
> + case KVM_EXIT_GUEST_PANICED:
> + monitor_protocol_event(QEVENT_GUEST_PANICED, NULL);
> + vm_stop(RUN_STATE_PANICED);
> + break;

This cannot work. You missed to set ret to -1 to break out of loop.

> case KVM_EXIT_INTERNAL_ERROR:
> ret = kvm_handle_internal_error(env, run);
> break;
> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> index f6b5343..ddc9716 100644
> --- a/linux-headers/linux/kvm.h
> +++ b/linux-headers/linux/kvm.h
> @@ -163,6 +163,7 @@ struct kvm_pit_config {
> #define KVM_EXIT_OSI 18
> #define KVM_EXIT_PAPR_HCALL 19
> #define KVM_EXIT_S390_UCONTROL 20
> +#define KVM_EXIT_GUEST_PANICED 21

Linux header must be sync'ed in a separate patch, referencing the
upstream (typically kvm.git) commit hash that was used as base. Make
sure to use the update-linux-headers.sh script for this.

So the ordering is: Get the kernel changes accepted, then push the
(final) user space patches. That said, a patch like this can still be
posted in advance for informational purposes, but not for application.

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux