linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: Re: [PATCH 0/3] power: max17042_battery: Add DT bindings
@ 2012-03-09  0:17 함명주
  2012-03-09 17:32 ` Karol Lewandowski
  0 siblings, 1 reply; 4+ messages in thread
From: 함명주 @ 2012-03-09  0:17 UTC (permalink / raw)
  To: Karol Lewandowski; +Cc: "DirkBrandewie<dirk.brandewie", linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 2576 bytes --]

Dear Karol Lewandowski,

I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.

Anyway, the patches themselves look fine.

However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.

Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)

Thank you.


Cheers!
MyungJoo.

------- Original Message -------
Sender : Karol Lewandowski<k.lewandowsk@samsung.com> Junior Software Engineer/SPRC-Linux (MSD)/»ï¼ºÀüÀÚ
Date : 2012-03-08 19:32 (GMT+09:00)
Title : Re: [PATCH 0/3] power: max17042_battery: Add DT bindings

Dear MyungJoo Ham,

Could you take a look at patchset I've sent? It's needed to make use of
max17042 driver on device tree-enabled platforms.

Regards,
-- 
Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform

On 22.02.2012 19:06, Karol Lewandowski wrote:

> Hi,
> 
> This series of patches adds bindings to max17042_battery driver making
> it possible to instantiate it from device tree description.
> 
> First, convience patch, simply replaces kzalloc with devm_kzalloc
> where possible.
> 
> Second, most intrusive patch adds variables orginally found only in
> platform data to max17042_chip structure.  I decided it to do it that
> way rather than allocating new platform data and then populating it
> from device tree description.
> 
> Last patch adds DT bindings itself.
> 
> I would be grateful for any comments and I will be more than happy to
> rework this patchset if needed.
> 
> 
> Karol Lewandowski (3):
>   max17042_battery: Use devm_kzalloc() where applicable
>   max17042_battery: Preserve properties outside of platform data
>   max17042_battery: Make it possible to instantiate driver from DT
> 
>  .../bindings/power_supply/max17042_battery.txt     |   18 +++++
>  drivers/power/max17042_battery.c                   |   77 ++++++++++++++++----
>  2 files changed, 79 insertions(+), 16 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power_supply/max17042_battery.txt
> 






--
MyungJoo Ham (ÇÔ¸íÁÖ), PHD
System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: Re: [PATCH 0/3] power: max17042_battery: Add DT bindings
@ 2012-03-12  1:53 함명주
  2012-03-12 14:34 ` Dirk Brandewie
  0 siblings, 1 reply; 4+ messages in thread
From: 함명주 @ 2012-03-12  1:53 UTC (permalink / raw)
  To: Karol Lewandowski
  Cc: DirkBrandewie, linux-kernel@vger.kernel.org,
	"AntonVorontsov<cbou",
	"DavidWoodhouse<dwmw2"

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 2651 bytes --]

Karol Lewandowski<k.lewandowsk@samsung.com>, 2012-03-10 02:32 (GMT+09:00)
> Dear MungJoo,
> 
> I wasn't aware of Dirk's patchset and thus, I didn't ever try to make my
> patches compatible with it.
> 
> I've found hopefully correct patchset[1] via google - it's mailing list
> posting without any feedback...  I've checked linux-next and it clearly
> hasn't been merged.
> 
> I'm happy to rework my patch but I would like to ask you about specific
> tree I should base on.  Is this patchset in some subsystem-specific
> (power?) tree? Other?

Dear Karol,

I preferred Dirk's patchset included because it is for the correctness of the device driver.

However, as Dirk's patchset has not been updated or merged for long, I guess you may go ahead trying to merge this DT patchset first.

It appears that this patchset does not force much trouble for Dirk's side as the two are virtually disjoint and it seems rebasing Dirk's patchset upon this patchset trivial though I didn't try that yet.

Anyway, please consider "Acked-by" from me for the patches.


Cheers!
MyungJoo.

> 
> [1] https://lkml.org/lkml/2012/1/24/237
> 
> Regards,
> -- 
> Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
> 
> On 09.03.2012 01:16, ÇÔ¸íÁÖ wrote:
> 
> > Dear Karol Lewandowski,
> > 
> > I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.
> > 
> > Anyway, the patches themselves look fine.
> > 
> > However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.
> > 
> > Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)
> > 
> > Thank you.
> > 
> > 
> > Cheers!
> > MyungJoo.
> > 
> > ------- Original Message -------
> > Sender : Karol Lewandowski Junior Software Engineer/SPRC-Linux (MSD)/»ï¼ºÀüÀÚ
> > Date : 2012-03-08 19:32 (GMT+09:00)
> > Title : Re: [PATCH 0/3] power: max17042_battery: Add DT bindings
> > 
> > Dear MyungJoo Ham,
> > 
> > Could you take a look at patchset I've sent? It's needed to make use of
> > max17042 driver on device tree-enabled platforms.
> > 
> > Regards,
> 
> 
> 
> 
> 

--

MyungJoo Ham (ÇÔ¸íÁÖ), PHD

System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858



 

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH 0/3] power: max17042_battery: Add DT bindings
@ 2012-02-22 18:06 Karol Lewandowski
  0 siblings, 0 replies; 4+ messages in thread
From: Karol Lewandowski @ 2012-02-22 18:06 UTC (permalink / raw)
  To: myungjoo.ham
  Cc: kyungmin.park, m.szyprowski, devicetree-discuss, linux-kernel,
	cbou, Karol Lewandowski

Hi,

This series of patches adds bindings to max17042_battery driver making
it possible to instantiate it from device tree description.

First, convience patch, simply replaces kzalloc with devm_kzalloc
where possible.

Second, most intrusive patch adds variables orginally found only in
platform data to max17042_chip structure.  I decided it to do it that
way rather than allocating new platform data and then populating it
from device tree description.

Last patch adds DT bindings itself.

I would be grateful for any comments and I will be more than happy to
rework this patchset if needed.


Karol Lewandowski (3):
  max17042_battery: Use devm_kzalloc() where applicable
  max17042_battery: Preserve properties outside of platform data
  max17042_battery: Make it possible to instantiate driver from DT

 .../bindings/power_supply/max17042_battery.txt     |   18 +++++
 drivers/power/max17042_battery.c                   |   77 ++++++++++++++++----
 2 files changed, 79 insertions(+), 16 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power_supply/max17042_battery.txt

-- 
1.7.8.3


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-12 14:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-09  0:17 Re: [PATCH 0/3] power: max17042_battery: Add DT bindings 함명주
2012-03-09 17:32 ` Karol Lewandowski
  -- strict thread matches above, loose matches on Subject: below --
2012-03-12  1:53 함명주
2012-03-12 14:34 ` Dirk Brandewie
2012-02-22 18:06 Karol Lewandowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).