From: Stephen Boyd <sboyd@codeaurora.org>
To: Yang Bai <hamo.by@gmail.com>
Cc: mmarek@suse.cz, rostedt@goodmis.org, adobriyan@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Makefile: fix error when gen TAGS
Date: Mon, 12 Mar 2012 00:52:16 -0700 [thread overview]
Message-ID: <4F5DAB30.3040409@codeaurora.org> (raw)
In-Reply-To: <CAO_0yfMGR=W+ocKER8EyKOB5ZKddOfbwnVb_Za_FDbPrZRaWBA@mail.gmail.com>
On 3/12/2012 12:50 AM, Yang Bai wrote:
> On Mon, Mar 12, 2012 at 3:34 PM, Stephen Boyd<sboyd@codeaurora.org> wrote:
>> Ah ok. How about this patch instead? Then we don't duplicate the sed
>> statement.
>>
>> ---->8-------
>>
>> diff --git a/scripts/tags.sh b/scripts/tags.sh
>> index 833813a..b390096 100755
>> --- a/scripts/tags.sh
>> +++ b/scripts/tags.sh
>> @@ -168,7 +168,7 @@ exuberant()
>>
>> --regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'
>>
>> # Remove structure forward declarations.
>> - LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct
>> \1;.*\$\/;"\tx$/d' tags
>> + LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct
>> \1;.*\$\/;"\tx$/d' $2
>> }
>>
>> emacs()
>> @@ -213,9 +213,9 @@ emacs()
>> xtags()
>> {
>> if $1 --version 2>&1 | grep -iq exuberant; then
>> - exuberant $1
>> + exuberant $1 $2
>> elif $1 --version 2>&1 | grep -iq emacs; then
>> - emacs $1
>> + emacs $1 $2
>> else
>> all_sources | xargs $1 -a
>> fi
>> @@ -244,11 +244,11 @@ case "$1" in
>>
>> "tags")
>> rm -f tags
>> - xtags ctags
>> + xtags ctags $1
>> ;;
>>
>> "TAGS")
>> rm -f TAGS
>> - xtags etags
>> + xtags etags $1
>> ;;
>> esac
>>
>>
>> But then with your next patch maybe it would be better to just have a flag?
>>
>> ----8<-----
>>
>> diff --git a/scripts/tags.sh b/scripts/tags.sh
>> index 833813a..4b1755d 100755
>> --- a/scripts/tags.sh
>> +++ b/scripts/tags.sh
>> @@ -166,9 +166,6 @@ exuberant()
>> all_defconfigs | xargs -r $1 -a \
>> --langdef=dotconfig --language-force=dotconfig \
>>
>> --regex-dotconfig='/^#?[[:blank:]]*(CONFIG_[[:alnum:]_]+)/\1/'
>> -
>> - # Remove structure forward declarations.
>>
>> - LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct
>> \1;.*\$\/;"\tx$/d' tags
>> }
>>
>> emacs()
>> @@ -233,6 +230,7 @@ if [ "${ARCH}" = "um" ]; then
>> fi
>> fi
>>
>> +remove_structs=
>> case "$1" in
>> "cscope")
>> docscope
>> @@ -244,11 +242,18 @@ case "$1" in
>>
>> "tags")
>> rm -f tags
>> - xtags ctags
>> + xtags ctags $1
> Why we need a $1 here??
>> + remove_structs=y
>> ;;
>>
>> "TAGS")
>> rm -f TAGS
>> - xtags etags
>> + xtags etags $1
> The same.
>> + remove_structs=y
>> ;;
>> esac
>> +
>> +# Remove structure forward declarations.
>> +if [ -n $remove_structs ]; then
>> + LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct
>> \1;.*\$\/;"\tx$/d' $1
>> +fi
>>
> This way is better but I don't understand why a $1 is there.
> I think it is useless and if you agree with me, i will send a fine patch to you.
It's a holdover from the previous patch. Thanks for spotting/removing it.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2012-03-12 7:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 3:53 [PATCH] Makefile: fix error when gen TAGS Yang Bai
2012-03-12 6:46 ` Stephen Boyd
2012-03-12 7:06 ` Yang Bai
2012-03-12 7:34 ` Stephen Boyd
2012-03-12 7:50 ` Yang Bai
2012-03-12 7:52 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5DAB30.3040409@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=adobriyan@gmail.com \
--cc=hamo.by@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox