Re: [PATCH] tile: remove a non-existing header

[Chris Metcalf <cmetcalf@tilera.com>]

On 3/12/2012 11:00 AM, Mauro Carvalho Chehab wrote:
> Em 12-03-2012 11:31, Chris Metcalf escreveu:
>> On 3/12/2012 10:18 AM, Mauro Carvalho Chehab wrote:
>>> While testing some API changes at the EDAC core, I've tested the EDAC
>>> drivers compilation on all supported architectures, including Tilera.
>>>
>>> I noticed that Tilera upstream code has issues: it doesn't compile with
>>> kernel 3.2:
>>>
>>> [...]
>> Thank you, but nack.  The header is provided in the latest gcc tip code. 
> Hmm... the gcc cross-compiler I've downloaded from Tilera site about one month
> ago didn't have it (tilegx-unknown-linux-gnu-gcc (GCC) 4.4.6).

Yes, I need to update it.  We've been focusing on the community return and
haven't updated our own web site recently :-)

>> Sorry for the API thrash!  It's certainly OK to comment it out for the time
>> being; it just provides some assembly macros for specifying feedback-guided
>> optimization.
> It would be a good idea then to add some Makefile magic to check it,
> maybe creating an empty linkage.h if the header is not found at the gcc
> toolchain, in order to support all gcc variants that support tile arch.

True, although, since there hasn't been an official release of gcc that
supports tile yet (the first will be 4.7), I'm less worried about
compatibility issues.  The gcc we ship to our customers has supported it
since day one, and 4.7 and following will support it, so it's just the
Tilera web site version, and I think it's OK for me to just update that one.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com