From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>,
Olof Johansson <olof@lixom.net>
Cc: Stephen Warren <swarren@nvidia.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Grant Likely <grant.likely@secretlab.ca>,
Colin Cross <ccross@android.com>,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V2 2/3] pinctrl: allow concurrent gpio and mux function ownership of pins
Date: Mon, 12 Mar 2012 12:24:35 -0600 [thread overview]
Message-ID: <4F5E3F63.5080506@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdYdSaNsrr34o2Cc4vS12ee9oY7FG0pxB92mefHZKwdEpA@mail.gmail.com>
On 03/06/2012 03:03 AM, Linus Walleij wrote:
> On Tue, Mar 6, 2012 at 1:22 AM, Stephen Warren <swarren@nvidia.com> wrote:
>
>> Per recent updates to Documentation/gpio.txt, gpiolib drivers should
>> inform pinctrl when a GPIO is requested. pinctrl then marks that pin as
>> in-use for that GPIO function.
>>
>> When an SoC muxes pins in a group, it's quite possible for the group to
>> contain e.g. 6 pins, but only 4 of them actually be needed by the HW
>> module that's mux'd to them. In this case, the other 2 pins could be
>> used as GPIOs. However, pinctrl marks all the pins within the group as
>> in-use by the selected mux function. To allow the expected gpiolib
>> interaction, separate the concepts of pin ownership into two parts: One
>> for the mux function and one for GPIO usage. Finally, allow those two
>> ownerships to exist in parallel.
>>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>
> Good, and 100% in accordance with earlier discussions.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Linus, now that Grant has ack'd and applied the documentation change
behind this, could you take this one patch into the pinctrl tree. I
assume it's 3.5 material. After the 3.4 merge window closes, I'll
probably come back and ask for a stable pinctrl branch that I can use as
the basis for a Tegra branch that'll contain patch 3 in this series.
(Olof, I assume that's the right way to approach this; having Linus
apply both patches 2/3 in this series to pinctrl is going to make life
difficult in the Tegra tree, since my outstanding patches to convert
Tegra to use pinctrl will touch many of the same files as patch 3 in
this series, in conflicting or dependent ways.)
Thanks.
next prev parent reply other threads:[~2012-03-12 18:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 0:22 [PATCH V2 1/3] Documentation/gpio.txt: Explain expected pinctrl interaction Stephen Warren
2012-03-06 0:22 ` [PATCH V2 2/3] pinctrl: allow concurrent gpio and mux function ownership of pins Stephen Warren
2012-03-06 10:03 ` Linus Walleij
2012-03-12 18:24 ` Stephen Warren [this message]
2012-03-12 21:42 ` Linus Walleij
2012-03-14 17:29 ` Olof Johansson
2012-03-14 17:27 ` Olof Johansson
2012-03-06 0:22 ` [PATCH V2 3/3] gpio: tegra: Hide tegra_gpio_enable/disable() Stephen Warren
2012-03-06 10:08 ` Linus Walleij
2012-03-06 17:01 ` Stephen Warren
2012-03-06 10:01 ` [PATCH V2 1/3] Documentation/gpio.txt: Explain expected pinctrl interaction Linus Walleij
2012-03-12 17:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E3F63.5080506@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=ccross@android.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).