From: Stephen Warren <swarren@wwwdotorg.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: Include <linux/bug.h> to prevent compile errors
Date: Mon, 12 Mar 2012 14:55:40 -0600 [thread overview]
Message-ID: <4F5E62CC.6030002@wwwdotorg.org> (raw)
In-Reply-To: <CACRpkdbkoahUiB01srfBzm1Qh2RQPw5P6BjmouuLETAqfQY6_Q@mail.gmail.com>
On 03/12/2012 01:44 PM, Linus Walleij wrote:
> On Fri, Mar 9, 2012 at 9:18 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> Macros in <linux/pinctrl/machine.h> call ARRAY_SIZE(), the definition of
>> which eventually calls BUILD_BUG_ON_ZERO(), which is defined in
>> <linux/bug.h>. Include that so that every .c file using the pinctrl macros
>> doesn't have to do that itself.
>
> I get this part...
...
>> diff --git a/include/linux/pinctrl/machine.h b/include/linux/pinctrl/machine.h
...
>> -#include "pinctrl-state.h"
>
> ?
>
>> +#include <linux/bug.h>
>> +
>> +#include "pinctrl.h"
>
> ?
>
> But I moved the states out of machine.h and pinctrl.h just so
> that we shouldn't have to include pinctrl.h into machine.h?
Oops. Looks like I completely screwed up a rebase there.
If Paul acks the concept of the patch, I'll repost.
prev parent reply other threads:[~2012-03-12 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 20:18 [PATCH] pinctrl: Include <linux/bug.h> to prevent compile errors Stephen Warren
2012-03-09 20:32 ` Paul Gortmaker
2012-03-09 20:43 ` Stephen Warren
2012-03-09 21:29 ` Paul Gortmaker
2012-03-09 23:09 ` Stephen Warren
2012-03-12 19:44 ` Linus Walleij
2012-03-12 20:55 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5E62CC.6030002@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox