From: Namhyung Kim <namhyung.kim@lge.com>
To: Arun Sharma <asharma@fb.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Tom Zanussi <tzanussi@gmail.com>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)
Date: Tue, 13 Mar 2012 10:36:31 +0900 [thread overview]
Message-ID: <4F5EA49F.7020706@lge.com> (raw)
In-Reply-To: <4F5E554C.4060209@fb.com>
Hi,
2012-03-13 4:58 AM, Arun Sharma wrote:
> On 3/12/12 11:21 AM, Arun Sharma wrote:
>>> BTW, I don't like the name 'inclusive' as a sort key. If it cares about
>>> time, IMHO, the name should contain 'time' - something like 'itime' or
>>> 'inctime'?
>>
>> The existing sort orders: pid, comm, dso, symbol, parent -- all care
>> about time, but none of them have time in their name?
>
> I'll take that back. What they sort on depends on the event.
>
> perf record -ge cache-misses
> perf report -s inclusive
>
> will sort by the number of cache-misses and not time.
>
> -Arun
AFAIK, "sort" here means how perf identifies a sample event from others:
"comm" will collect samples have same pid/comm, then "dso" will group samples
belong to same library, and "symbol" will group again samples have same symbol
name. This is what default sort order (comm,dso,symbol) does.
In case of "inclusive" it does same thing with "symbol" as you use sort_sym
for the inclusive sort_dimension. Sorting by period for output is done at
final stage and it won't be affected by any sort orders. It maybe sound
confusing but that's how it works.
Thanks,
Namhyung
next prev parent reply other threads:[~2012-03-13 1:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 22:41 [PATCH 0/2] perf: add sort by inclusive time functionality (v2) Arun Sharma
2012-03-07 22:41 ` [PATCH 1/2] perf: refactor add_hist_entry() code paths Arun Sharma
2012-03-07 22:41 ` [PATCH 2/2] perf: Add a new sort order: SORT_INCLUSIVE Arun Sharma
2012-03-07 23:13 ` Arun Sharma
2012-03-08 7:22 ` Ingo Molnar
2012-03-12 19:35 ` Arun Sharma
2012-03-08 15:39 ` Frederic Weisbecker
2012-03-08 18:22 ` Arun Sharma
2012-03-13 13:44 ` Frederic Weisbecker
2012-03-08 7:29 ` [PATCH 0/2] perf: add sort by inclusive time functionality (v2) Ingo Molnar
2012-03-08 15:31 ` Frederic Weisbecker
2012-03-08 18:49 ` Arun Sharma
2012-03-12 7:15 ` Namhyung Kim
2012-03-12 18:05 ` Arun Sharma
2012-03-13 1:11 ` Namhyung Kim
2012-03-12 7:43 ` Namhyung Kim
2012-03-12 18:21 ` Arun Sharma
2012-03-12 19:58 ` Arun Sharma
2012-03-13 1:36 ` Namhyung Kim [this message]
2012-03-15 14:50 ` Frederic Weisbecker
2012-03-15 17:41 ` Arun Sharma
2012-03-13 1:16 ` Namhyung Kim
2012-03-13 18:45 ` Arun Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5EA49F.7020706@lge.com \
--to=namhyung.kim@lge.com \
--cc=acme@redhat.com \
--cc=asharma@fb.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox