From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759034Ab2CMRpT (ORCPT ); Tue, 13 Mar 2012 13:45:19 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:54612 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758667Ab2CMRpR (ORCPT ); Tue, 13 Mar 2012 13:45:17 -0400 Message-ID: <4F5F879E.4030407@gmail.com> Date: Tue, 13 Mar 2012 12:45:02 -0500 From: Rob Herring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Sascha Hauer , Dong Aisheng CC: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vinod.koul@linux.intel.com, rob.herring@calxeda.com, grant.likely@secretlab.ca, rdunlap@xenotime.net, kernel@pengutronix.de, cjb@laptop.org, shawn.guo@freescale.com Subject: Re: [PATCH v1 3/5] ARM: imx28evk: add mmc dt support References: <1331628428-24017-1-git-send-email-b29396@freescale.com> <1331628428-24017-4-git-send-email-b29396@freescale.com> <4F5F5C22.1080506@gmail.com> <20120313165214.GO26642@pengutronix.de> In-Reply-To: <20120313165214.GO26642@pengutronix.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2012 11:52 AM, Sascha Hauer wrote: > On Tue, Mar 13, 2012 at 09:39:30AM -0500, Rob Herring wrote: >> On 03/13/2012 03:47 AM, Dong Aisheng wrote: >>> From: Dong Aisheng >>> >>> Signed-off-by: Dong Aisheng >>> --- >>> arch/arm/boot/dts/imx28-evk.dts | 14 ++++++++++++++ >>> arch/arm/boot/dts/imx28.dtsi | 33 +++++++++++++++++++++++++++++++++ >>> arch/arm/mach-mxs/imx28-dt.c | 2 ++ >>> 3 files changed, 49 insertions(+), 0 deletions(-) >> >> snip >> >>> diff --git a/arch/arm/mach-mxs/imx28-dt.c b/arch/arm/mach-mxs/imx28-dt.c >>> index 78d1129..429b88e 100644 >>> --- a/arch/arm/mach-mxs/imx28-dt.c >>> +++ b/arch/arm/mach-mxs/imx28-dt.c >>> @@ -23,6 +23,8 @@ static const struct of_dev_auxdata imx28_auxdata_lookup[] __initconst = { >>> OF_DEV_AUXDATA("arm,pl011", MX28_DUART_BASE_ADDR, "duart", NULL), >>> OF_DEV_AUXDATA("fsl,imx28-fec", MX28_ENET_MAC0_BASE_ADDR, "imx28-fec.0", NULL), >>> OF_DEV_AUXDATA("fsl,imx28-fec", MX28_ENET_MAC1_BASE_ADDR, "imx28-fec.1", NULL), >>> + OF_DEV_AUXDATA("fsl,imx28-mmc", MX28_SSP0_BASE_ADDR, "mxs-mmc.0", NULL), >>> + OF_DEV_AUXDATA("fsl,imx28-mmc", MX28_SSP1_BASE_ADDR, "mxs-mmc.1", NULL), >> >> Why is this needed? > > These are needed for the drivers which have still the mxs-mmc.* names > to find their clocks. Alternatively we could also add the appropriate > clocks to the clock file. Don't know if that's better though. Ah, yes I should have known that... If clk lookup is all that's needed, I'd suggest adding the necessary clk lookups either here or in the clock code. Not much difference, but at least it removes the use of *_BASE_ADDR defines. Rob